Skip to content

change constructor prototype to allow const pin arrays #42

Description

@JM-FRANCE

It's annoying to not be able to declare the rows and cols pins or the keys as const without having a compile time warning.

Please change the constructor prototype to document the fact that you are not messing around with the arrays and thus they can be const.

please go for:

Keypad::Keypad(const char *userKeymap, const byte *row, const byte *col, byte numRows, byte numCols)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions