Make the generated PWA worker contract fresh-checkout safe - #2402
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dist/NetworkFirststrategy, and no legacytaskdeck-api-cacheThis changes test and workflow ownership only. It does not change production PWA cache policy.
Verification
dotnet test backend/Taskdeck.sln -c Release(backend untouched)npm run test:pwa-generated-workerfrom absentdist/: production worker generated with 142 precache entries; 3/3 passednpm run typecheck: passednpm run lint: passed with 0 errors and 8 pre-existing warningsnpm run test:coverage -- --maxWorkers=2: 364 files, 5,378 passed, 3 skipped; thresholds passednode --test scripts/ci/smart-ci/*.test.mjs: 80/80 passedgit diff --check: passed33698716037, CI Extended/Workflow Lint33698716014, Smart CI shadow33698751239, and branch-dispatched nightly33698730513: passedPre-fix reproduction from a clean checkout failed 2/2 with
ENOENTfordist/sw.js. One broad coverage run at the Europe/London versus UTC midnight boundary failed five untouched due-date tests; all 100 affected-file tests passed underTZ=UTC, and the single post-midnight full rerun passed.Documentation
docs/STATUS.mdupdated (no shipped product behavior changed)docs/IMPLEMENTATION_MASTERPLAN.mdupdated (no roadmap change)docs/TESTING_GUIDE.mdupdated with the nightly generated-worker validation step after PR docs: record the v0.3 integration wave #2394 released the fileCLAUDE_SYNC_PACKETdocs/TESTING_GUIDE.mdnow records generated PWA worker generation/validation before nightly frontend coverageb66da8fd43eebad7ee3a7c21c38df7e48fe9ed9733698730513passedTracking
CI Workflow Validation
nightly-quality.ymldispatch33698730513ond612c1fed42fa3650dd94387bb62408ab69496d0Risk Notes