Bound board detail loads and cancel stale reads - #2419
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Chris0Jeky
left a comment
There was a problem hiding this comment.
Bounded fresh-context review complete for current head becefcd130b3dee0488254e72aa9fe816570e0f0 against eaa996fa2c70b13335d1628ccd66b33771fa6779.
Round 1 found collateral behavior: the initial path-wide /boards interceptor also disabled retries for unrelated provenance, access, and comment reads. Fix commit c51f56a3 removed that global mutation, scoped the 10 second/no-auto-retry policy to the explicit board/cards/labels fan-out, and added a nested-provenance regression.
Round 2 found no CRITICAL/HIGH defect in timeout propagation, cancellation, generation guards, loaded-state preservation, or cleanup. The current-base interaction pass confirmed PR #2417 changed only backend capture/configuration files and did not overlap or interact with this seven-file frontend diff.
Verified at the current head: 103 focused tests, typecheck and production build, scoped ESLint, and diff hygiene. No browser proof is claimed because Paper/Legacy Retry controls are the declared residual behind PR #2397.
Non-blocking P2 declined for this slice: an intentional Axios abort can still emit safe Network Error reporting noise before stale-result suppression. It is not user-facing, and changing shared error reporting is outside this bounded foundation.
Summary
Scope
This is the disjoint transport/store foundation for #1721. It does not close the issue. Paper and Legacy Retry controls plus browser recovery proof remain after PR #2397 releases
BoardView.vueandPaperBoardView.vue.Product trust
A held-open board-detail request now reaches a bounded failure instead of leaving the core board route loading indefinitely. Failed or superseded refreshes cannot overwrite newer state, and already-loaded board data stays visible for the later explicit Retry path.
Verification
npx vitest --run --maxWorkers=2 src/tests/api/http.spec.ts src/tests/store/board/boardCrudStore.spec.ts src/tests/api/boardsApi.spec.ts src/tests/api/cardsApi.spec.ts src/tests/api/labelsApi.spec.ts: 103 passednpm run build: passed, includingvue-tsc -band production Vite/PWA buildgit diff --check origin/main...HEAD: passedReview
Round 1 found that a path-wide
/boardsinterceptor would also remove retries from unrelated provenance/access/comment reads. Commitc51f56a3narrowed the policy to the explicit three-call board load and added a regression. Round 2 and the current-base interaction review found no CRITICAL/HIGH defect.Non-blocking P2 declined for this slice: intentional Axios aborts can still emit safe
Network Errorconsole/reporting noise before the store suppresses the stale result. It is not user-facing, and changing global error reporting is outside this bounded board-load foundation.Not verified here
Refs #1721