Skip to content

Bound board detail loads and cancel stale reads - #2419

Merged
Chris0Jeky merged 3 commits into
mainfrom
codex-1721/board-load-bounds
Sep 3, 2026
Merged

Bound board detail loads and cancel stale reads#2419
Chris0Jeky merged 3 commits into
mainfrom
codex-1721/board-load-bounds

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Summary

  • give the board, cards, and labels detail fan-out an explicit 10 second deadline and skip automatic retries so the caller reaches a terminal state
  • abort the prior generation and still-pending siblings, suppress stale results, and commit board data only when the whole current generation succeeds
  • preserve the last loaded board, cards, and labels when a refresh fails
  • add focused regressions for timeout options, cancellation, stale generations, state preservation, and unrelated nested board reads

Scope

This is the disjoint transport/store foundation for #1721. It does not close the issue. Paper and Legacy Retry controls plus browser recovery proof remain after PR #2397 releases BoardView.vue and PaperBoardView.vue.

Product trust

A held-open board-detail request now reaches a bounded failure instead of leaving the core board route loading indefinitely. Failed or superseded refreshes cannot overwrite newer state, and already-loaded board data stays visible for the later explicit Retry path.

Verification

  • npx vitest --run --maxWorkers=2 src/tests/api/http.spec.ts src/tests/store/board/boardCrudStore.spec.ts src/tests/api/boardsApi.spec.ts src/tests/api/cardsApi.spec.ts src/tests/api/labelsApi.spec.ts: 103 passed
  • npm run build: passed, including vue-tsc -b and production Vite/PWA build
  • scoped ESLint on all seven changed files: passed
  • git diff --check origin/main...HEAD: passed
  • pre-fix broader frontend regression run: 5,406 passed, 3 skipped; the final scope fix was then re-proved with the focused 103 tests and build

Review

Round 1 found that a path-wide /boards interceptor would also remove retries from unrelated provenance/access/comment reads. Commit c51f56a3 narrowed the policy to the explicit three-call board load and added a regression. Round 2 and the current-base interaction review found no CRITICAL/HIGH defect.

Non-blocking P2 declined for this slice: intentional Axios aborts can still emit safe Network Error console/reporting noise before the store suppresses the stale result. It is not user-facing, and changing global error reporting is outside this bounded board-load foundation.

Not verified here

Refs #1721

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-03T05:24:07.980200Z becefcd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Chris0Jeky Chris0Jeky moved this from Pending to Review in Taskdeck Execution Sep 3, 2026

@Chris0Jeky Chris0Jeky left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bounded fresh-context review complete for current head becefcd130b3dee0488254e72aa9fe816570e0f0 against eaa996fa2c70b13335d1628ccd66b33771fa6779.

Round 1 found collateral behavior: the initial path-wide /boards interceptor also disabled retries for unrelated provenance, access, and comment reads. Fix commit c51f56a3 removed that global mutation, scoped the 10 second/no-auto-retry policy to the explicit board/cards/labels fan-out, and added a nested-provenance regression.

Round 2 found no CRITICAL/HIGH defect in timeout propagation, cancellation, generation guards, loaded-state preservation, or cleanup. The current-base interaction pass confirmed PR #2417 changed only backend capture/configuration files and did not overlap or interact with this seven-file frontend diff.

Verified at the current head: 103 focused tests, typecheck and production build, scoped ESLint, and diff hygiene. No browser proof is claimed because Paper/Legacy Retry controls are the declared residual behind PR #2397.

Non-blocking P2 declined for this slice: an intentional Axios abort can still emit safe Network Error reporting noise before stale-result suppression. It is not user-facing, and changing shared error reporting is outside this bounded foundation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant