Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the app/extension to v5.0 (build 72) and refactors several Quick Search + Shortcuts/AppIntents behaviors, including a new setting to disable editing search engines from Shortcuts and changes to how Quick Search Engines are saved and refreshed.
Changes:
- Version bump to 5.0 / build 72 across the Xcode project and extension manifests.
- Quick Search: extracted
QuickSearchSettingsView, refreshedQuickSEListViewstate onUserDefaultschanges, and updated UI copy/localizations. - Shortcuts/AppIntents: added a global “disable editing from Shortcuts” gate, consolidated intent enums/support, and refactored Safari extension URL handling.
Reviewed changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| Shared/Enums.swift | Converts QuickSearchKeywordPos.default to a static let. |
| Shared/CSEDataManager.swift | Refactors QuickCSE saving (auto-key generation) and adds helper(s). |
| Shared/AppInitializer.swift | Simplifies early-exit logic via guard. |
| Localizable.xcstrings | Updates/cleans up localization keys; adds new setting strings. |
| Customize Search Engine.xcodeproj/xcshareddata/xcschemes/CSE.xcscheme | Changes Run/Launch build configuration to Debug. |
| Customize Search Engine.xcodeproj/project.pbxproj | Updates marketing/build versions to 5.0 / 72. |
| CSE/Views/QuickSEListView.swift | Updates footer text and refreshes QuickSE state on defaults changes. |
| CSE/Views/QuickSearchSettingsView.swift | Moves Quick Search settings UI into its own file. |
| CSE/Views/EditSEView/EditSEViewSupport.swift | Updates saving flow for non-throwing save + keyword change handling. |
| CSE/Views/EditSEView/EditSEView.swift | Simplifies toolbar/back behavior; always saves on disappear. |
| CSE/Views/AdvSettingView.swift | Adds “Disable Editing Search Engine from Shortcuts” toggle. |
| CSE/AppIntents/SetUseQuickSearch.swift | Uses centralized enums + blocks edits when disabled. |
| CSE/AppIntents/SetUseEmojiSearch.swift | Uses centralized enums + blocks edits when disabled. |
| CSE/AppIntents/SetPrivateSE.swift | Blocks edits when disabled. |
| CSE/AppIntents/SetDefaultSE.swift | Blocks edits when disabled. |
| CSE/AppIntents/IntentSupport.swift | New shared intent support (enums + settings gate). |
| CSE/AppIntents/IntentEnums.swift | Removes old standalone intent enums. |
| CSE/AppIntents/GetCSESettings.swift | Switches to centralized intent settings enum. |
| CSE/AppIntents/DeleteQuickSE.swift | Blocks edits when disabled. |
| CSE/AppIntents/AddQuickSE.swift | Removes replace flow; now uses non-throwing save path. |
| CSE/AppIcons/pride.icon/icon.json | Updates icon material/features configuration. |
| CSE Extension/SafariWebExtensionHandler.swift | Refactors engine/query detection + CSE selection logic; cleanup. |
| CSE Extension/Resources/manifest.json | Bumps extension version to 5.0. |
| CSE Extension/Resources/background.js | Simplifies incognito tracking + message handling. |
| CSE ContentBlocker/Resources/manifest.json | Bumps content blocker version to 5.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.