Skip to content

Harden shell execution: fail loudly on missing test directory #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohaelmrabet merged 1 commit into from
Aug 30, 2026
Merged

Harden shell execution: fail loudly on missing test directory #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Console/DevTestsRunCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,11 @@ protected function execute(InputInterface $input, OutputInterface $output): int
foreach ($runCommands as $key) {
[$dir, $options] = $this->commands[$key];
$dirName = realpath(BP . '/dev/tests/' . $dir);
if ($dirName === false) {
$output->writeln('<error>Test directory not found: ' . BP . '/dev/tests/' . $dir . '</error>');
$failures[] = 'missing directory: ' . $dir;
continue;
}
chdir($dirName);
// Build ParaTest command
$command = sprintf(
Expand All @@ -116,6 +121,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int
$command .= ' ' . $commandArguments;
}
$this->logCommand($output, $dirName, $command);
// $commandArguments is passed through unescaped, same as Magento's native
// dev:tests:run: it is meant to carry multiple shell tokens (e.g. "--filter=Foo bar.php"),
// so escaping the whole string would break that. This command is a local dev CLI tool
// invoked directly by the developer, not fed untrusted input from a remote caller.
// passthru() call have to be here.
// phpcs:ignore Magento2.Security.InsecureFunction
passthru($command, $returnVal);
Expand Down
24 changes: 24 additions & 0 deletions Test/Unit/Console/DevTestsRunCommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,4 +174,28 @@ public function testProcessesCannotBeBelowOne()
$tester->getDisplay()
);
}

public function testMissingTestDirectoryIsReportedAsFailure()
{
global $devTestsRunCommandTestResult;
$devTestsRunCommandTestResult = 0;

$dir = BP . '/dev/tests/unit';
rename($dir, $dir . '.bak');

try {
$tester = new CommandTester($this->command);
$tester->execute([DevTestsRunCommand::INPUT_ARG_TYPE => 'unit']);

$output = $tester->getDisplay();
$this->assertStringContainsString(
'Test directory not found',
$output,
'A missing test directory should be reported instead of chdir()-ing into it blindly'
);
$this->assertStringContainsString('FAILED - ', $output);
} finally {
rename($dir . '.bak', $dir);
}
}
}
Loading