Add client hostname option - #1173
Open
OrangeFlag wants to merge 1 commit into
Open
Conversation
|
|
OrangeFlag
force-pushed
the
client-hostname-option
branch
3 times, most recently
from
June 30, 2026 16:05
ac5547a to
674f977
Compare
OrangeFlag
force-pushed
the
client-hostname-option
branch
from
June 30, 2026 16:25
674f977 to
8a26fed
Compare
Contributor
Author
|
@kavirajk can you review this PR? |
Contributor
Author
|
@kavirajk ping |
kavirajk
reviewed
Jul 24, 2026
kavirajk
left a comment
kavirajk
left a comment
Contributor
There was a problem hiding this comment.
Thanks @OrangeFlag. Left few minor comments.
| } else { | ||
| clientName = fmt.Sprintf("%s %s", clientName, opt.ClientName) | ||
| } | ||
| clientName := formatClientName(opt.ClientName, pkg) |
Contributor
There was a problem hiding this comment.
do you think we can add some tests for this format? to avoid any future regression?
| InitialAddress: c.conn.LocalAddr().String(), | ||
| OSUser: "", | ||
| ClientHostname: "", | ||
| ClientHostname: c.hostname, |
Contributor
There was a problem hiding this comment.
Also some tests to make sure we have non-empty hostname would help?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClientInfo.ClientHostname.ClientNamein clickhouse-go style: application product first, then ch-go product.ClientName, for example:application/v1.85.2 clickhouse/ch-go/0.71.0 (lv:go/1.26.4; os:linux).Motivation
ClickHouse query logs expose both
client_hostnameandclient_name. Applications need to use these fields for different attribution dimensions:client_hostname: pod or host identity.client_name: application/library identity and versions.This makes it easier to filter by service/version and separately group by pod/host.
Checklist