feat(proto): support Variant type - #1183
Draft
nikandfor wants to merge 1 commit into
Draft
Conversation
nikandfor
marked this pull request as draft
August 3, 2026 09:06
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Variant is the first head of the three-headed one (#939) — long wanted, never quite within reach.
It doesn't need to invent new mechanics, so I took the liberty (humbly) — it's built from the same blocks as Tuple, Map and LowCardinality: a state prefix, child columns, and the usual Encode/Decode/Prepare/Infer propagation.
Only basic access functions are implemented. That's the minimal basis — enough to read and write every value. Fancier helpers can land separately; a couple of ideas:
Columns must be in ClickHouse order, i.e. sorted by type name, since discriminators are indices into that list. Prepare reports columns that are out of order or duplicated.
for changelog
AI was used heavily — and I stand behind every line and symbol.
Checklist
Delete items not relevant to your PR: