github_repos: preserve cursor after partial fetch failures - #245
Open
fallintoplace wants to merge 1 commit into
Open
github_repos: preserve cursor after partial fetch failures#245fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
fallintoplace
force-pushed
the
fix/github-repos-partial-failure-cursor
branch
from
August 1, 2026 15:55
893f5ed to
b0c9b45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
github_reposuses one timestamp cursor across every configured repository. A repository fetch failure was converted to an empty list, making it indistinguishable from a successful repository with no issues.If another repository returned a newer item, the shared cursor advanced past unseen items in the failed repository. Those items were then permanently excluded after the repository recovered.
Fix
Successful records may be fetched again while the cursor is held; inbox persistence deduplicates unchanged retries by source and ID.
Verification
Regression coverage exercises raised and returned failures, a two-run recovery where the previously missed item is recovered, and incomplete first-run baseline creation.
.venv/bin/python -m pytest -q tests/test_github_repos_source.py tests/test_source_filters.py: 34 passed