Skip to content

Fabricate CMIP7 coverage by repeating the final year - #887

Draft
lewisjared wants to merge 2 commits into
mainfrom
fix/fabricate-by-repeating-last-year
Draft

Fabricate CMIP7 coverage by repeating the final year#887
lewisjared wants to merge 2 commits into
mainfrom
fix/fabricate-by-repeating-last-year

Conversation

@lewisjared

Copy link
Copy Markdown
Contributor

Reworks how fabricated CMIP7 test data reaches years the CMIP6 source never ran. The series used to be relabelled onto the requested end date, which dragged every real year along with it. It is now padded instead, by repeating the final year until it reaches that date, so the real timesteps keep their real dates and values.

Two things worth a close look.

  • The relabelling was applied per file, so a dataset split into chunks (GFDL-ESM4 toz is 1850-1949 plus 1950-2014) produced overlapping files that all ended on the same month. Padding only ever touches the tail, so that goes away.
  • The fabricated tail is now a repeat of the last real year rather than real data under a different label. Either way it is invented, but a reviewer should be happy with a flat repeated year showing up in the fire and cloud radiative effects plots.

Re-mints the two affected CMIP7 baselines. Their fabricated files move from 185701-202112 to 185001-202112.

The ozone diagnostics need this to ask for a 1950 start on CMIP7, so #886 should land after it.

The CMIP6 source for a fabricated CMIP7 series stops in 2014, so the series was relabelled
onto the requested end date. This moved every real year with it, and each file was relabelled
on its own, so a dataset split across several chunks ended up with overlapping files that all
finished on the same month.

Replaces the relabelling with padding. The real timesteps keep their dates and values, and the
final year is tiled forward until the series reaches the requested end.

Re-mints the fire and cloud radiative effects CMIP7 baselines, whose fabricated files now start
in 1850 rather than 1857.
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...limate-ref-core/src/climate_ref_core/esgf/cmip7.py 0.00% 1 Missing ⚠️
Flag Coverage Δ
core 93.76% <95.83%> (+<0.01%) ⬆️
providers 87.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...te-ref-core/src/climate_ref_core/cmip6_to_cmip7.py 94.49% <100.00%> (+0.14%) ⬆️
...esmvaltool/diagnostics/climate_drivers_for_fire.py 100.00% <ø> (ø)
...limate-ref-core/src/climate_ref_core/esgf/cmip7.py 87.30% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant