Fabricate CMIP7 coverage by repeating the final year - #887
Draft
lewisjared wants to merge 2 commits into
Draft
Conversation
The CMIP6 source for a fabricated CMIP7 series stops in 2014, so the series was relabelled onto the requested end date. This moved every real year with it, and each file was relabelled on its own, so a dataset split across several chunks ended up with overlapping files that all finished on the same month. Replaces the relabelling with padding. The real timesteps keep their dates and values, and the final year is tiled forward until the series reaches the requested end. Re-mints the fire and cloud radiative effects CMIP7 baselines, whose fabricated files now start in 1850 rather than 1857.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks how fabricated CMIP7 test data reaches years the CMIP6 source never ran. The series used to be relabelled onto the requested end date, which dragged every real year along with it. It is now padded instead, by repeating the final year until it reaches that date, so the real timesteps keep their real dates and values.
Two things worth a close look.
tozis 1850-1949 plus 1950-2014) produced overlapping files that all ended on the same month. Padding only ever touches the tail, so that goes away.Re-mints the two affected CMIP7 baselines. Their fabricated files move from
185701-202112to185001-202112.The ozone diagnostics need this to ask for a 1950 start on CMIP7, so #886 should land after it.