Repository navigation
Ship the pinned Japanese dictionary with application builds - #254
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Application packages currently omit the Japanese dictionary and require a separate install. This change includes the pinned, independently versioned resource in full source archives and Electron resources, then selects it by default through the existing loader.
An explicit independent installation still wins, so updates and rollbacks survive application upgrades. Personal
assets/text/ja/user.csvand saved settings remain untouched. Existing independent format-1 installs also retain their chosen version; the documentation explains how to return to the bundled default.Delivery and release boundary
2026.10.22.1-rc2and its nine exact files inrelease/japanese_dictionary.json. All 134,201 master/source rows and existing review classifications are preserved. No pronunciation data or admission rules change.Validation
The committed acceptance receipt binds implementation
92d45b8ato the actual full resource and local archive. The later commit only adds the receipt/documentation.correct_pronunciation_for_tts→clean_textwith the real native Japanese frontend: menu, game, Disney, 中立派. All 134,201 source rows load. This verifies delivery/loading, not newly synthesized audio; resource bytes are unchanged from previous listening acceptance.pyopenjtalk-plus==0.4.1.post9successfully ran the resource probe; no full model environment is needed for that release check.Resource ZIP SHA-256:
a935b3adfded9022afe3b2384cebc2ef1e4023f54f48df1f9ded9ff45b896989.Qualified local application archive SHA-256:
c1761b41baa005cc96c8556c1fe1511ffa845a70cc24bd944ee35418fbcd971c(implementation92d45b8a, an acceptance artifact, not a published release).PR CI uses code-only packaging and synthetic native lifecycle fixtures on Windows/Linux/macOS; it does not claim access to the unpublished real resource. Full-resource artifact qualification was performed locally on Windows. The Electron frontend continues to use the existing separate Python installation contract.