Skip to content

Ship the pinned Japanese dictionary with application builds - #254

Merged
Lucas1479 merged 3 commits into
mainfrom
codex/bundled-japanese-dictionary
Oct 22, 2026
Merged

Lucas1479 merged 3 commits into
mainfrom
codex/bundled-japanese-dictionary

Conversation

@Lucas1479

Copy link
Copy Markdown
Member

Application packages currently omit the Japanese dictionary and require a separate install. This change includes the pinned, independently versioned resource in full source archives and Electron resources, then selects it by default through the existing loader.

An explicit independent installation still wins, so updates and rollbacks survive application upgrades. Personal assets/text/ja/user.csv and saved settings remain untouched. Existing independent format-1 installs also retain their chosen version; the documentation explains how to return to the bundled default.

Delivery and release boundary

  • Pin 2026.10.22.1-rc2 and its nine exact files in release/japanese_dictionary.json. All 134,201 master/source rows and existing review classifications are preserved. No pronunciation data or admission rules change.
  • Full application builds fail if the resource is missing or mismatched. Electron passes its actual packaged resource path to the Python backend; compiled caches remain outside the bundled resource directory.
  • Developer/PR packages must use an explicitly labelled code-only configuration. Tag/full manual builds require the exact approved resource ZIP and run real native frontend probes against both extracted sources and the packaged resource.
  • The download URL is intentionally unset while the resource is unpublished. No application version bump, tag or release is included.
  • Keep this PR draft and unmerged. Wait for the console UI/UX work and combined acceptance before considering a merge or publication.

Validation

The committed acceptance receipt binds implementation 92d45b8a to the actual full resource and local archive. The later commit only adds the receipt/documentation.

  • 166 focused Python tests passed; 19 final archive/delivery tests passed after the final CLI adjustment.
  • Electron build and full Windows unpacked packaging passed; the packaged resource contains exactly the nine pinned files. The explicit code-only package omits it.
  • Actual source extraction and Electron-resource loading passed through correct_pronunciation_for_tts → clean_text with the real native Japanese frontend: menu, game, Disney, 中立派. All 134,201 source rows load. This verifies delivery/loading, not newly synthesized audio; resource bytes are unchanged from previous listening acceptance.
  • Actual old format-1 → rc2 bundled upgrade, independent install/update/rollback, application upgrade after rollback, and return to the bundled default all passed. Personal Menu → メヌー continued to work, and personal/settings bytes stayed unchanged. The existing live installation was not modified.
  • Local Electron tests: 537 passed; one existing Vite integration test failed because localhost:5173 was already occupied. The existing service was left running. CI will exercise it on a clean runner.
  • Core environment plus pinned pyopenjtalk-plus==0.4.1.post9 successfully ran the resource probe; no full model environment is needed for that release check.

Resource ZIP SHA-256: a935b3adfded9022afe3b2384cebc2ef1e4023f54f48df1f9ded9ff45b896989.

Qualified local application archive SHA-256: c1761b41baa005cc96c8556c1fe1511ffa845a70cc24bd944ee35418fbcd971c (implementation 92d45b8a, an acceptance artifact, not a published release).

PR CI uses code-only packaging and synthetic native lifecycle fixtures on Windows/Linux/macOS; it does not claim access to the unpublished real resource. Full-resource artifact qualification was performed locally on Windows. The Electron frontend continues to use the existing separate Python installation contract.

@Lucas1479
Lucas1479 marked this pull request as ready for review October 22, 2026 16:05
@Lucas1479
Lucas1479 merged commit 48f23ac into main Oct 22, 2026
17 checks passed
@Lucas1479
Lucas1479 deleted the codex/bundled-japanese-dictionary branch October 22, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant