Skip to content

fix: upgrade weak hash in face_controller_3d.py (CWE-328) - #8

Open
anupamme wants to merge 1 commit into
Code2Collapse:mainfrom
anupamme:fix-repo-comfyui-wananimatepreprocessv2-cwe-328-md5-cache-key
Open

anupamme wants to merge 1 commit into
Code2Collapse:mainfrom
anupamme:fix-repo-comfyui-wananimatepreprocessv2-cwe-328-md5-cache-key

Conversation

@anupamme

@anupamme anupamme commented Oct 9, 2026

Copy link
Copy Markdown

MD5 is used for generating cache keys in multiple locations for 3D face and pose processing. MD5 is cryptographically broken and vulnerable to collision attacks, allowing attackers who control input data to craft different inputs that produce identical hashes, potentially bypassing integrity checks or poisoning caches. The affected code is nodes_extras/face_controller_3d.py:1279. This change is the fix I would apply.

Reference: CWE-328

What changed

  • nodes_extras/face_controller_3d.py

Verification

No automated check could be run against this repository, so this change is unverified beyond review. Please treat it as a suggestion.


Automated security fix by OrbisAI Security

Automated security fix generated by OrbisAI Security
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant