fix: resolve last remaining analyzer findings (CA1001, CA1031, CA1515, CA1711, CA1822, CA1861) - #165
Merged
Merged
Conversation
…, CA1711, CA1822, CA1861) Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the analyzer-hardening tail that remains after the merged analyzer series. With
AnalysisMode=All, main currently produces exactly 30 warnings (16 unique sites) across six rules — all in the audio-cue service, its test doubles, and PDF table headers. This PR zeroes them so theDirectory.Build.propstightening toAnalysisMode=All+TreatWarningsAsErrorscan land without breaking CI.SerialAudioQueue: suppression w/ justification (app-lifetime singleton, BlockingCollection intentionally never disposed)SerialAudioQueue.Run+SystemAlarmService.PlayBlocking: suppression w/ justification (pattern already used in this file)SerialAudioQueue→internal sealed(already only referenced insideLageBuch.App, tests access viaInternalsVisibleTo)IAlarmService.Start()/Stop()impls: suppression w/ justification (interface members cannot be static)new[] { … }toprivate static readonly string[] HeaderTitlesVerification
origin/main(37dae99): build withEnableNETAnalyzers + AnalysisLevel=latest + AnalysisMode=All→ only those six rules drop to 0; 0 errors; no other-rule deltas.