feat(java): detect FormValidation handlers executing outbound HTTP without permission check (CWE-918) - #127
Open
ai-anant wants to merge 1 commit into
Conversation
…thout permission check (CWE-918)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New rule:
codevigilant.java.jenkins.ssrf.formvalidation-httpclient-execute.Detects Stapler form-validation / test-connection handlers (methods returning hudson.util.FormValidation, typically doCheck*/doTestConnection) that perform an outbound HTTP request via Apache HttpClient execute(...) without any permission check. Such handlers run on the Jenkins controller; when the request URL derives from stored credentials or configuration, an attacker can make the controller send credentialed requests to attacker-chosen hosts and observe reachability/status feedback (SSRF oracle, CWE-918, plus missing authorization CWE-862).
semgrep --validate(semgrep 1.172.0)