feat(java): detect CanonicalIdResolver subclasses resolving identities without an authorization check (CWE-290) - #130
Open
ai-anant wants to merge 2 commits into
Conversation
… members (CWE-284)
…s without an authorization check (CWE-290)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rule: CanonicalIdResolver subclass without authorization check (CWE-290)
Adds a Java rule detecting
hudson.model.User.CanonicalIdResolversubclasses whoseresolveCanonicalIdimplementation performs no permission check.Generic vulnerable shape
Why it matters
User.CanonicalIdResolveris a global extension point consulted byUser.get(...)whenever an ID or full name is resolved, including authentication flows and SCM
committer mapping. When the mapping is derived from unverified, user-editable data,
an attacker can claim another user's identifier and redirect every name→user
resolution for it (attribution spoofing, notification/approval redirection, login
binding confusion). Resolvers must verify identity ownership or require an
authorization check before returning a canonical ID.
Rule
codevigilant.java.jenkins.identityresolution.missing-authorizationsemgrep --validate --config java/passes