London | 26-May-ITP | Yonatan Teklemariam | Sprint 2 | exercises#1237
Open
Yonatanteklemariam wants to merge 8 commits into
Open
London | 26-May-ITP | Yonatan Teklemariam | Sprint 2 | exercises#1237Yonatanteklemariam wants to merge 8 commits into
Yonatanteklemariam wants to merge 8 commits into
Conversation
Yonatanteklemariam
added
the
Needs Review
…irm if it is working. all checked passed.
Yonatanteklemariam
changed the title
Yonatanteklemariam
removed
the
Needs Review
Yonatanteklemariam
added
the
Needs Review
Author
|
Hi @LonMcGregor, how are you? I hope you're well. Could you please go through my exercises and give me your feedback? Thanks |
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 22, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, I have a few comments
| // When passed to tally | ||
| // Then it should return an empty object | ||
| test("tally on an empty array returns an empty object", () => { | ||
| expect([]).toEqual({}); |
There was a problem hiding this comment.
I get a failure when I run this test, can you find out why?
| }); | ||
| }); | ||
|
|
||
| test("prints country and currency vertically", () => { |
There was a problem hiding this comment.
Typically the point of using tests is to test the output, if the output is correct, then we can trust that anything printed should be correct. This means we don't want a function under test to print anything. With that in mind, what is the purpose of this test?
| if (typeof item !== "string" || !/^[A-Za-z0-9]+$/.test(item)) { | ||
| throw new Error("Please Enter Valid Input!"); | ||
| } | ||
| counts[item] = (counts[item] ?? 0) + 1; |
There was a problem hiding this comment.
Can you explain how ?? works here?
|
|
||
| // a) What is the current return value when invert is called with { a : 1 } | ||
| // take only the values | ||
| const values = entries.map(([_, v]) => v); |
There was a problem hiding this comment.
Instead of getting the entries, then mapping for the values, is there a faster route to getting the values?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
debugged all the three functions and fixed them.
implemented the contains() and wrote the tests for it, re-run all of them. all tests checked/passed.