Birmingham | 26-ITP-May | Ogbemi Mene | Sprint 1 | Module data group/sprint 1#1254
Open
meneogbemi42-bit wants to merge 4 commits into
Open
Birmingham | 26-ITP-May | Ogbemi Mene | Sprint 1 | Module data group/sprint 1#1254meneogbemi42-bit wants to merge 4 commits into
meneogbemi42-bit wants to merge 4 commits into
Conversation
meneogbemi42-bit
added
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 22, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, but I have a few comments.
Also, Did you remember to write some test cases for the "implement" tasks?
| return null; | ||
| } | ||
| const numbersOnly = list.filter(element => typeof element === 'number'); | ||
| //console.log (numbersOnly); |
There was a problem hiding this comment.
If this code isn't needed, remove commented out parts completely
| //return median; | ||
| } | ||
|
|
||
| const salaries = [10, 40, 50, 70, 90] |
There was a problem hiding this comment.
If you have test files, put the tests into those ones rather than leaving them in the main file
| return []; | ||
| } | ||
|
|
||
| return [...new Set(list)]; |
| if (numbersOnly.length === 0) { | ||
| return -Infinity; | ||
| } | ||
| return Math.max(...numbersOnly); |
There was a problem hiding this comment.
Could you maybe try re-implementing this without using the built-in max function?
|
|
||
| const numbersOnly = elements.filter(item => typeof item === "number" && !isNaN(item)); | ||
|
|
||
| if (numbersOnly.length === 0) { |
There was a problem hiding this comment.
If you have 0 elements, do you need this if condition here?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
This PR is about implementing and fixing array manipulation functions as part of a Sprint 1 coding exercise.