Skip to content

[T-051c] S-GRID and S-OFAT predefined baselines #102

Closed

Description

@CodewithJha

Task T-051c · Milestone M4 — Baselines + metrics + experiments · Size S · Priority P1 · Epic #4

Implements FR-SEL-001 · PR-04

Branch feat/t-051c-s-grid-and-s-ofat — one task = one branch = one PR (doc 32 §6)

Summary

Implement GridStrategy (k = floor(B^(1/d)), min 2; seeded permutation if k^d > B) and OFATStrategy (levels {0, .25, .5, .75, 1} per parameter from nominal; cycled with fresh seeds if B is larger) with is_exhausted().

Context / motivation

S-OFAT encodes a conscientious manual test plan that cannot find interactions by design — the key contrast for H3.

Scope

In scope

  • selection/baselines/grid.py, selection/baselines/ofat.py; entry points S-GRID, S-OFAT.

Implementation guidance

  • OFAT levels and grid minimum come from SelectionDefaults; nominal from the space (pins respected).
  • Standards: respect the layering contracts (doc 16 §2) and conventions in doc 34; no hard-coded tunables — thresholds/defaults come from typed settings (doc 27); no magic numbers (ruff PLR2004); public APIs typed (mypy strict) and documented.

Configuration keys

From the configuration reference (doc 27). Keys marked (new) must be added to the typed settings models and appear in the generated reference (T-003c).

  • selection.ofat.levels
  • selection.grid.min_levels

Acceptance criteria

  • Contract suite passes (exhaustion semantics).
  • OFAT total distinct scenarios = d·|L| (30 for d=6).
  • Tests listed below added and green in CI; coverage of new code meets the gate in doc 18 §3.
  • Docs, config reference and CHANGELOG Unreleased updated where behaviour, keys or interfaces changed.
  • Definition of Done (doc 32 §3) satisfied.

Tests required

  • tests/unit/selection/test_grid_ofat.py.

Dependencies

Blocked by: #84 (T-050a)

Blocks: no other task (leaf)

Parallelization notes

Files / paths owned by this task — avoid editing other paths; shared files (pyproject.toml entry points, cli/main.py, api/routers/__init__.py, router.tsx, docker/compose.yaml, ci.yml) are append-only:

  • backend/src/roboprobe/selection/baselines/grid.py
  • backend/src/roboprobe/selection/baselines/ofat.py

Parallel with T-051a/b.

Definition of Done

Per doc 32 §3 and AGENTS.md §5: lint, format, mypy strict and import-linter green; tests added and passing; docs updated; PR template completed with Closes #<this issue>; Conventional Commit messages referencing T-051c (doc 16 §6); commits authored only by the repository owner identity (AGENTS.md §4); CI green; reviewer checklist (doc 32 §5.1) satisfied.

References

Design docs: doc 07 §3 · doc 19 §1

Requirements: FR-SEL-001 · PR-04 (traceability: doc 28)

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:selectionScenario selection strategies (BO, LSE, PROBE, baselines)milestone:M4M4 — Baselines + metrics + experimentspriority:P1Required for milestone exitsize:S<= 1 daytaskChild task of a milestone epictype:featureNew functionality

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions