Skip to content

[T-086a] Components: ConditionStrip, SpecimenTag, VerdictNotch (SVG, accessible names) #166

Closed

Description

@CodewithJha

Task T-086a · Milestone M8 — Dashboard · Size S · Priority P0 · Epic #8

Implements FR-DSH-008 · NFR-ACC-001

Branch feat/t-086a-components-conditionstrip-specimentag-verdictnotch-svg — one task = one branch = one PR (doc 32 §6)

Summary

Implement the three signature identity components per doc 13 §6 with props exactly as specified, colour + shape encodings (verdict ○ ✕ ◆), tooltips via Radix, and aria-labels describing values in physical units.

Context / motivation

These appear on almost every screen; doing them once enables all screens.

Scope

In scope

  • Storybook-free: component docs via Vitest + a /dev/components route (dev only).

Implementation guidance

  • ConditionStrip props exactly per doc 13 §6: values: number[] (unit 0–1), labels: string[], highlight?: number[], size: 'xs'|'sm'|'md', plus optional formatted?: string[] (physical values for the tooltip). Renders d vertical bars in an SVG (role="img", aria-label="speed 0.42 m/s (high), light 12 lux (low) …"); highlighted bars use --ink, others --ink-muted.
  • SpecimenTag: kind: 'run'|'mode', id, verdict, label, strip?; punched-hole motif via a CSS pseudo-element; mono id; rendered as a <Link>, keyboard focusable, aria-label includes the verdict word.
  • VerdictNotch: verdict: 'PASS'|'FAIL'|'INVALID', shape + colour (○ --verdict-pass, ✕ --verdict-fail, ◆ --verdict-invalid) with visually hidden text.
  • Each component folder: Component.tsx, Component.module.css, Component.test.tsx, index.ts; no data fetching, no global state.
  • Dev-only gallery route /dev/components (excluded from production via import.meta.env.DEV) for manual QA and the token visual snapshot (doc 18 §4.10).
  • Standards: respect the layering contracts (doc 16 §2) and conventions in doc 34; no hard-coded tunables — thresholds/defaults come from typed settings (doc 27); no magic numbers (ruff PLR2004); public APIs typed (mypy strict) and documented.

Acceptance criteria

  • Unit tests for props/states; axe check on rendered components shows 0 violations.
  • Colour-blind safe (shape always accompanies colour).
  • Tooltip reachable by keyboard focus, not hover only.
  • Gallery route absent from the production bundle (build test).
  • Tests listed below added and green in CI; coverage of new code meets the gate in doc 18 §3.
  • Docs, config reference and CHANGELOG Unreleased updated where behaviour, keys or interfaces changed.
  • Definition of Done (doc 32 §3) satisfied.

Tests required

  • web/src/components/{ConditionStrip,SpecimenTag,VerdictNotch}/*.test.tsx.

Dependencies

Blocked by: #162 (T-085a)

Blocks: #169 (T-087a), #170 (T-087b), #172 (T-088b), #173 (T-089a), #176 (T-110a)

Parallelization notes

Files / paths owned by this task — avoid editing other paths; shared files (pyproject.toml entry points, cli/main.py, api/routers/__init__.py, router.tsx, docker/compose.yaml, ci.yml) are append-only:

  • web/src/components/ConditionStrip/**
  • web/src/components/SpecimenTag/**
  • web/src/components/VerdictNotch/**

Parallel with T-086b/c.

Definition of Done

Per doc 32 §3 and AGENTS.md §5: lint, format, mypy strict and import-linter green; tests added and passing; docs updated; PR template completed with Closes #<this issue>; Conventional Commit messages referencing T-086a (doc 16 §6); commits authored only by the repository owner identity (AGENTS.md §4); CI green; reviewer checklist (doc 32 §5.1) satisfied.

References

Design docs: doc 13 §6 · doc 13 §1

Requirements: FR-DSH-008 · NFR-ACC-001 (traceability: doc 28)

External:

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:dashboardReact web dashboardmilestone:M8M8 — Dashboardpriority:P0Critical path / blocks otherssize:S<= 1 daytaskChild task of a milestone epictype:featureNew functionality

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions