Skip to content

[T-119] Release images workflow images.yml: build & push to GHCR, Trivy scan, SBOM (Syft), provenance #189

Closed

Description

@CodewithJha

Task T-119 · Milestone M8 — Dashboard · Size S · Priority P1 · Epic #8

Implements NFR-DEP-001 · NFR-SEC-002

Branch ci/t-119-release-images-workflow-build-push — one task = one branch = one PR (doc 32 §6)

Summary

Create .github/workflows/images.yml building roboprobe-backend and roboprobe-web (and later roboprobe-gazebo) for linux/amd64 (+arm64 where feasible), pushing to GHCR on tags and main, Trivy scan failing on HIGH/CRITICAL fixable vulns, Syft SBOM attached, build provenance attestations.

Context / motivation

Doc 20 §6 release flow; images are what users deploy (doc 29).

Scope

In scope

  • Image tags: semver, sha-<short>, edge for main.

Implementation guidance

  • .github/workflows/images.yml: triggers push to main (tags edge, sha-<short>), tags v* (semver tags via docker/metadata-action), pull_request (build only, push: false) and workflow_call (reused by release.yml, T-124).
  • Matrix over images: backend, web, and later gazebo (amd64 only, enabled once T-095 lands, guarded with hashFiles).
  • Steps: setup-qemu-action + setup-buildx-action; GHCR login with GITHUB_TOKEN; build-push-action with cache-from/to: type=gha, provenance: mode=max, sbom: true; aquasecurity/trivy-action (severity: HIGH,CRITICAL, ignore-unfixed: true, exit-code: 1) uploading SARIF to code scanning; anchore/sbom-action (Syft SPDX JSON) as an artefact; actions/attest-build-provenance for pushed digests.
  • Image names ghcr.io/codewithjha/roboprobe-{backend,web,gazebo} (lower-case owner, matching doc 27 backends.gazebo_nav2.image).
  • Pin all actions by commit SHA (Dependabot keeps them updated, T-006c).
  • Standards: respect the layering contracts (doc 16 §2) and conventions in doc 34; no hard-coded tunables — thresholds/defaults come from typed settings (doc 27); no magic numbers (ruff PLR2004); public APIs typed (mypy strict) and documented.

Acceptance criteria

  • Workflow runs on a test tag in a fork/dry-run; scans and SBOM produced.
  • A PR run builds without pushing.
  • Trivy SARIF visible in code scanning.
  • Actions pinned by SHA.
  • Tests listed below added and green in CI; coverage of new code meets the gate in doc 18 §3.
  • Docs, config reference and CHANGELOG Unreleased updated where behaviour, keys or interfaces changed.
  • Definition of Done (doc 32 §3) satisfied.

Tests required

  • Workflow dry-run (push: false on PRs).

Dependencies

Blocked by: #26 (T-005a), #185 (T-116)

Blocks: #221 (T-124)

Parallelization notes

Files / paths owned by this task — avoid editing other paths; shared files (pyproject.toml entry points, cli/main.py, api/routers/__init__.py, router.tsx, docker/compose.yaml, ci.yml) are append-only:

  • .github/workflows/images.yml

CI-only.

Definition of Done

Per doc 32 §3 and AGENTS.md §5: lint, format, mypy strict and import-linter green; tests added and passing; docs updated; PR template completed with Closes #<this issue>; Conventional Commit messages referencing T-119 (doc 16 §6); commits authored only by the repository owner identity (AGENTS.md §4); CI green; reviewer checklist (doc 32 §5.1) satisfied.

References

Design docs: doc 20 §1 · doc 20 §6 · doc 31 §3

Requirements: NFR-DEP-001 · NFR-SEC-002 (traceability: doc 28)

External:

Activity

  1. added this to the M8 — Dashboard milestone on Nov 19, 2026
  2. added
    type:infraCI, build, deployment infrastructure
    area:ciCI/CD workflows
    area:deployDocker images, compose, release packaging
    area:securitySecurity hardening, supply chain
    priority:P1Required for milestone exit
    taskChild task of a milestone epic
    on Nov 19, 2026
  3. added a commit that references this issue on Nov 21, 2026
    b780391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:ciCI/CD workflowsarea:deployDocker images, compose, release packagingarea:securitySecurity hardening, supply chainmilestone:M8M8 — Dashboardpriority:P1Required for milestone exitsize:S<= 1 daytaskChild task of a milestone epictype:infraCI, build, deployment infrastructure

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions