Repository navigation
Description
Task
T-119· Milestone M8 — Dashboard · Size S · Priority P1 · Epic #8Implements NFR-DEP-001 · NFR-SEC-002
Branch
ci/t-119-release-images-workflow-build-push— one task = one branch = one PR (doc 32 §6)
Summary
Create .github/workflows/images.yml building roboprobe-backend and roboprobe-web (and later roboprobe-gazebo) for linux/amd64 (+arm64 where feasible), pushing to GHCR on tags and main, Trivy scan failing on HIGH/CRITICAL fixable vulns, Syft SBOM attached, build provenance attestations.
Context / motivation
Doc 20 §6 release flow; images are what users deploy (doc 29).
Scope
In scope
- Image tags: semver,
sha-<short>,edgefor main.
Implementation guidance
.github/workflows/images.yml: triggerspushtomain(tagsedge,sha-<short>), tagsv*(semver tags viadocker/metadata-action),pull_request(build only,push: false) andworkflow_call(reused byrelease.yml, T-124).- Matrix over images:
backend,web, and latergazebo(amd64 only, enabled once T-095 lands, guarded withhashFiles). - Steps:
setup-qemu-action+setup-buildx-action; GHCR login withGITHUB_TOKEN;build-push-actionwithcache-from/to: type=gha,provenance: mode=max,sbom: true;aquasecurity/trivy-action(severity: HIGH,CRITICAL,ignore-unfixed: true,exit-code: 1) uploading SARIF to code scanning;anchore/sbom-action(Syft SPDX JSON) as an artefact;actions/attest-build-provenancefor pushed digests. - Image names
ghcr.io/codewithjha/roboprobe-{backend,web,gazebo}(lower-case owner, matching doc 27backends.gazebo_nav2.image). - Pin all actions by commit SHA (Dependabot keeps them updated, T-006c).
- Standards: respect the layering contracts (doc 16 §2) and conventions in doc 34; no hard-coded tunables — thresholds/defaults come from typed settings (doc 27); no magic numbers (ruff
PLR2004); public APIs typed (mypy strict) and documented.
Acceptance criteria
- Workflow runs on a test tag in a fork/dry-run; scans and SBOM produced.
- A PR run builds without pushing.
- Trivy SARIF visible in code scanning.
- Actions pinned by SHA.
- Tests listed below added and green in CI; coverage of new code meets the gate in doc 18 §3.
- Docs, config reference and CHANGELOG
Unreleasedupdated where behaviour, keys or interfaces changed. - Definition of Done (doc 32 §3) satisfied.
Tests required
- Workflow dry-run (
push: falseon PRs).
Dependencies
Blocked by: #26 (T-005a), #185 (T-116)
Blocks: #221 (T-124)
Parallelization notes
Files / paths owned by this task — avoid editing other paths; shared files (pyproject.toml entry points, cli/main.py, api/routers/__init__.py, router.tsx, docker/compose.yaml, ci.yml) are append-only:
.github/workflows/images.yml
CI-only.
Definition of Done
Per doc 32 §3 and AGENTS.md §5: lint, format, mypy strict and import-linter green; tests added and passing; docs updated; PR template completed with Closes #<this issue>; Conventional Commit messages referencing T-119 (doc 16 §6); commits authored only by the repository owner identity (AGENTS.md §4); CI green; reviewer checklist (doc 32 §5.1) satisfied.
References
Design docs: doc 20 §1 · doc 20 §6 · doc 31 §3
Requirements: NFR-DEP-001 · NFR-SEC-002 (traceability: doc 28)
External:
Metadata
Metadata
Assignees
Labels
Projects
- StatusShow more project fieldsBacklog
Activity
/config.json, CSP & security headers, composewebservice #185release.yml: on tag → images, GitHub Release with CHANGELOG section, SBOMs, demo report #221ci(release): verify tags and publish scanned images (#293)