Repository navigation
Description
Task
T-005b· Milestone M1 — Foundation · Size S · Priority P1 · Epic #1Implements NFR-DEP-001 · PR-13
Branch
ci/t-005b-compose-profile-postgres-17-with— one task = one branch = one PR (doc 32 §6)
Summary
Create docker/compose.yaml with the core profile skeleton (postgres + one-shot migrate) and dev profile port publishing, plus Makefile targets, so make up starts an empty, healthy stack.
Context / motivation
M1 exit criterion: make up starts an empty stack. Services for api/orchestrator/worker/web are added later by their own tasks (T-047, T-116, T-095).
Scope
In scope
postgres(digest-pinnedpostgres:17,POSTGRES_PASSWORD_FILEfrom Docker secretdb_password,pg_isreadyhealthcheck, named volumepgdata, port 5432 published only indevprofile).migrateone-shot service using the backend image; until T-010b it runsroboprobe --version(placeholder) — command switched toroboprobe db upgradein T-045a.x-backendanchor per doc 17 §4.1.- Makefile:
up,down,db-up,logs,ps;secrets/db_passwordgenerated bymake setupif missing (git-ignored). - Compose variables from doc 27 §4.12 with defaults.
Implementation guidance
- Bind published ports to
127.0.0.1only (doc 21 §1). Usedepends_on: {postgres: {condition: service_healthy}}. All variables come from.env; nothing hard-coded except image names/tags defaults. - Standards: respect the layering contracts (doc 16 §2) and conventions in doc 34; no hard-coded tunables — thresholds/defaults come from typed settings (doc 27); no magic numbers (ruff
PLR2004); public APIs typed (mypy strict) and documented.
Configuration keys
From the configuration reference (doc 27). Keys marked (new) must be added to the typed settings models and appear in the generated reference (T-003c).
ROBOPROBE_IMAGE_TAGROBOPROBE_DB_NAMEROBOPROBE_DB_USER
Acceptance criteria
-
make up→ postgres healthy, migrate exits 0;make downcleans up. - Postgres not reachable from the host unless
--profile dev. -
secrets/and.envare git-ignored. - Tests listed below added and green in CI; coverage of new code meets the gate in doc 18 §3.
- Docs, config reference and CHANGELOG
Unreleasedupdated where behaviour, keys or interfaces changed. - Definition of Done (doc 32 §3) satisfied.
Tests required
- Manual verification steps in PR; automated compose smoke test arrives with T-047/T-117a.
Dependencies
Blocked by: #26 (T-005a)
Blocks: #97 (T-047), #185 (T-116), #200 (T-095), #220 (T-128)
Parallelization notes
Files / paths owned by this task — avoid editing other paths; shared files (pyproject.toml entry points, cli/main.py, api/routers/__init__.py, router.tsx, docker/compose.yaml, ci.yml) are append-only:
docker/compose.yaml- Makefile (compose targets)
- .gitignore (secrets/)
docker/compose.yaml is later extended by T-047 (orchestrator/worker), T-116 (web), T-095 (gazebo), T-125 (observability) — those tasks add new service blocks only.
Definition of Done
Per doc 32 §3 and AGENTS.md §5: lint, format, mypy strict and import-linter green; tests added and passing; docs updated; PR template completed with Closes #<this issue>; Conventional Commit messages referencing T-005b (doc 16 §6); commits authored only by the repository owner identity (AGENTS.md §4); CI green; reviewer checklist (doc 32 §5.1) satisfied.
References
Design docs: doc 17 §4 · doc 17 §4.1 · doc 29 §3 · doc 21 §1 · doc 27 §4.12 · ADR-0013
Requirements: NFR-DEP-001 · PR-13 (traceability: doc 28)
External:
Metadata
Metadata
Assignees
Labels
Projects
- StatusShow more project fieldsIn review
Activity
make demo#97/config.json, CSP & security headers, composewebservice #185docker/gazebo/Dockerfile): pinned Jazzy/Harmonic/Nav2, ros_ws build, worker venv, composegazeboprofile #200make backup|restore(pg_dump + artefacts), verified restore test #220