Skip to content

[T-006a] CI workflow ci.yml: lint, typecheck, backend unit/property/contract matrix, integration, web tests #28

Closed

Description

@CodewithJha

Task T-006a · Milestone M1 — Foundation · Size M · Priority P0 · Epic #1

Implements NFR-MNT-001 · NFR-PORT-001

Branch ci/t-006a-ci-workflow-lint-typecheck-backend — one task = one branch = one PR (doc 32 §6)

Summary

Create .github/workflows/ci.yml with the PR pipeline of doc 20 §1–§2 (jobs that make sense at M1; placeholders for later jobs are added by their own tasks).

Context / motivation

Green CI on every PR is part of the Definition of Done and the M1 exit criterion (make setup && make test green on CI).

Scope

In scope

  • Jobs: lint (ruff, ruff-format check, mypy, import-linter, ESLint, Prettier), test-backend (matrix ubuntu-latest/macos-latest; -m 'unit or property or contract' with xdist), test-integration (Postgres 17 service container, ROBOPROBE_TEST_DATABASE_URL), test-web (Vitest), build-web, config-docs-check (T-003c).
  • Caching: astral-sh/setup-uv keyed on uv.lock, pnpm store, Hypothesis DB.
  • JUnit XML + coverage summary in job summary (doc 20 §8); coverage gate 85 % (raise to per-package gates later).
  • Least-privilege permissions: contents: read; concurrency group cancels superseded runs.
  • Triggers: push to main, pull_request (never pull_request_target, doc 31 TM-11).

Out of scope

  • benchmark-smoke (T-053)
  • openapi-check (T-084b)
  • security/license jobs (T-006c)
  • images (T-119)

Implementation guidance

  • Pin third-party actions by full commit SHA with a version comment. Use ROBOPROBE_ENV=ci. Set HYPOTHESIS_PROFILE=ci. Upload coverage XML as artefact (no paid service).
  • Standards: respect the layering contracts (doc 16 §2) and conventions in doc 34; no hard-coded tunables — thresholds/defaults come from typed settings (doc 27); no magic numbers (ruff PLR2004); public APIs typed (mypy strict) and documented.

Acceptance criteria

  • Workflow green on a PR for the skeleton.
  • Required-check names match doc 20 §3 (lint, test-backend (ubuntu-latest), test-integration, test-web, build-web).
  • Total duration ≤ 10 min.
  • No secrets used besides GITHUB_TOKEN.
  • Tests listed below added and green in CI; coverage of new code meets the gate in doc 18 §3.
  • Docs, config reference and CHANGELOG Unreleased updated where behaviour, keys or interfaces changed.
  • Definition of Done (doc 32 §3) satisfied.

Tests required

  • The workflow itself; verify failure by pushing a deliberately failing commit on a scratch branch (note in PR).

Dependencies

Blocked by: #12 (T-001), #13 (T-007), #14 (T-009), #25 (T-017)

Blocks: #30 (T-006c), #31 (T-132)

Parallelization notes

Files / paths owned by this task — avoid editing other paths; shared files (pyproject.toml entry points, cli/main.py, api/routers/__init__.py, router.tsx, docker/compose.yaml, ci.yml) are append-only:

  • .github/workflows/ci.yml

Later tasks add new jobs to ci.yml (append-only blocks) — rebase before merge.

Definition of Done

Per doc 32 §3 and AGENTS.md §5: lint, format, mypy strict and import-linter green; tests added and passing; docs updated; PR template completed with Closes #<this issue>; Conventional Commit messages referencing T-006a (doc 16 §6); commits authored only by the repository owner identity (AGENTS.md §4); CI green; reviewer checklist (doc 32 §5.1) satisfied.

References

Design docs: doc 20 §1 · doc 20 §2 · doc 20 §3 · doc 20 §4 · doc 20 §8 · doc 18 §2 · doc 18 §3 · doc 31 §3

Requirements: NFR-MNT-001 · NFR-PORT-001 (traceability: doc 28)

External:

Activity

  1. added this to the M1 — Foundation milestone on Nov 19, 2026
  2. added
    type:infraCI, build, deployment infrastructure
    area:ciCI/CD workflows
    priority:P0Critical path / blocks others
    taskChild task of a milestone epic
    on Nov 19, 2026
  3. 5 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:ciCI/CD workflowsmilestone:M1M1 — Foundationpriority:P0Critical path / blocks otherssize:M1-3 daystaskChild task of a milestone epictype:infraCI, build, deployment infrastructure

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions