Skip to content

fix(gazebo): use the measured warehouse bridge and pallet geometry (T-091) - #340

Merged
cursor[bot] merged 7 commits into
mainfrom
fix/T-091-live-bridge-contract
Nov 22, 2026
Merged

cursor[bot] merged 7 commits into
mainfrom
fix/T-091-live-bridge-contract

Conversation

@Reet24-del

@Reet24-del Reet24-del commented Nov 22, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Follow up on #335 and #190 with the measured Jazzy contract. Make scan and command paths distinct, use the Gazebo PointCloudPacked stream through the ROS PointCloud2 bridge, and record the model-scoped pose topic that produced an actual PoseStamped message. The velocity delay input comes after collision monitoring.

The settled lidar plane is 0.188 m above the floor. Spawned a 0.135 m collision box for the dropped pallet, leaving 53 mm of nominal clearance below the beam plane. The checked-in capture documents the installed packages, frames, QoS, Nav2 parameters, actual point and pose messages, and a real TwistStamped bridge conversion.

Test evidence

  • Captured live ROS and Gazebo warehouse output on the pinned T-090 image and spawned the corrected pallet at z=0.0675 m.
  • 166 focused schema, task, and profile tests passed. The contract asserts distinct topics, type-matched velocity endpoints, point-cloud types and the same pallet box in SDF and the task file.
  • Regenerated the actual 60-run and three-mode seed dataset on PostgreSQL, restored its SQL and artifacts into a second database, and exported all seven current API responses. The original seeded campaign, experiment and representative run IDs survived. The measured demo space version 2b4d5a96d21a pins its archived task and nominal CSV.
  • Restored deterministic seed ID generation after feat(api): start planned experiments on request (T-084a) #327 moved the SQL experiment writer. Ruff and strict mypy pass for that script.

Package integration

The installed ROS package includes the pallet model and accepts the measured transient-local AMCL pose QoS. The Jazzy package passed 16 tests after integrating the initial pose topic and map frame from #346. The materializer consumes this contract in #350.

@cursor
cursor Bot force-pushed the fix/T-091-live-bridge-contract branch from 7be16f8 to 03f9c5a Compare November 22, 2026 20:36
@cursor
cursor Bot force-pushed the fix/T-091-live-bridge-contract branch from 03f9c5a to 0c0d965 Compare November 22, 2026 20:37
cursor Bot pushed a commit that referenced this pull request Nov 22, 2026
## Summary

Degrade the Gazebo OAK-D point cloud using the episode's light level and
the versioned perception model. The relay keeps the input header and
applies radial range noise without moving the surviving points off their
original camera rays.

## Links

- Task T-093c, FR-SIM-003
- Closes #194
- The measured Gazebo topic aliases are tracked by #340. Episode wiring
and generated parameters are tracked by #199 and #201.

## Changes

- Install a standalone Jazzy `perception_degrader` console entry point
with distinct input and output topics and depth-one sensor QoS.
- Use the existing vendored perception model and seeded generator.
Discard invalid and lost returns and log the processing time for each
cloud.

## Test evidence

- Isolated Jazzy container on one CPU using Fast DDS. All six package
tests passed. The new DDS test checks determinism, retention at 5, 50,
and 500 lux, radial coordinates, frame and timestamp, and QoS with
320×240 points. Measured reference-size processing in the local
validation was under 13 ms versus a 100 ms camera period.
- Ruff and formatting passed for the edited ROS Python files. Strict
mypy passed for the new module with untyped ROS imports ignored. Vendor
drift check and `git diff --check` passed.

## Checklist (Definition of Done — docs/32 §3)

- [x] Added Jazzy DDS and setup regression tests. Hosted CI checks the
exact head.
- [x] Reuses the existing typed perception model path. Updated
integration docs and the unreleased changelog.
- [x] Commit uses the repository owner identity.

## Risk & rollback

The new relay is a standalone ROS entry point. The supported Gazebo
launch will pass its episode files and the verified topic map. Revert
this commit to remove the entry point and restore the previous package.

---------

Co-authored-by: CodewithJha <155089480+CodewithJha@users.noreply.github.com>
@cursor
cursor Bot merged commit 19ab1f3 into main Nov 22, 2026
23 checks passed
@cursor
cursor Bot deleted the fix/T-091-live-bridge-contract branch November 22, 2026 21:36
cursor Bot pushed a commit that referenced this pull request Nov 22, 2026
#350)

## Summary

Generate deterministic Gazebo episode inputs from the validated
scenario, SUT profile and task. The generated workdir carries the SDF
world, Nav2 parameters, perturbations, bridge bindings and files
required by the ROS launch and recorder.

Closes #201

## Links

- Task T-096a
- Requirements FR-SIM-003 and FR-SCN-005
- Depends on #340 for the measured default topic catalog and installed
pallet model. The verified warehouse task came from #342.

## Changes

- Apply P1–P8 to their individual SDF, Nav2 and perturbation fields.
Initialize ROS components with independently derived seeds.
- Add the stable episode configuration and workdir-local topic catalog,
occupancy map and perception model.
- Disable XML entity expansion, DTD loading and parser network access.
Reject declarations before using the world.
- Document the workdir inputs consumed by the launch, recorder and
subprocess worker.

## Test evidence

- 27 materializer tests passed, including golden files and
field-by-field P1–P8 coverage. Targeted branch-inclusive coverage was
above 85%. Ruff and strict mypy passed.
- Real Jazzy Nav2 configuration and Harmonic warehouse SDF generated a
loadable warehouse with the dropped pallet. Jazzy accepted all nine
generated bridge routes.
- The current catalog includes the measured AMCL QoS, initial pose topic
and map frame from #340 and #346.

## Checklist

- [x] Added and ran focused materialization and invalid-input tests.
- [x] Updated design docs, traceability and Unreleased changelog.
- [x] Kept commit authorship to the repository owner.
- [ ] GitHub checks complete and #340 merged.

## Risk and rollback

The episode format is new. The runtime manifest remains the
responsibility of the subprocess worker that has the run identity and
environment metadata.

---------

Co-authored-by: CodewithJha <155089480+CodewithJha@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants