Repository navigation
fix(deps): patch Expo glob and minimatch build chains - #598
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm audit --omit=devreported 19 affected package names (18 Moderate, 1 Low) through Expo and instrumentation tooling. Scoped overrides use glob 14.0.3 and minimatch 11.0.3; the Istanbul chain uses test-exclude 8.0.0 so it can consume the modern minimatch API. The existing Expo CLI zod override is preserved.The repeat audit reports 7 Low package names from the single deepmerge advisory GHSA-gcqx-w48m-w2h4. There is no published patched deepmerge release; the residual build dependency risk remains. The actual packaged 60-package server closure contains none of these three libraries. This is a dependency remediation, with no application-source changes.
Compared the manifest diff with Dependabot #593. This PR adds scoped overrides; #593 updates broader direct dependencies and will need lockfile regeneration when combined.
Validation passed: npm ci, npm audit --omit=dev --json (expected non-zero exit for the retained Low advisory), npm run test:fast (133 root, 985 server, 1,674 frontend passed), npm run build:web, npm run test:slow, frontend/server coverage, npm run test:a11y, format, lint, architecture and typecheck.
Local-only authenticated ZAP scan and repeat completed with DOM XSS rule 40026 disabled, no AJAX spider, and 3-minute rule/25-minute scan limits. Owner/outsider read and mutation probes passed, including valid owner media capabilities. Raw SQL alerts in the repeat failed two authenticated reproduction rounds and remain explicitly triaged; the known inline-style CSP risk is retained. No hosted active scan was run. The report evidence and qualification limits are in the separate report workspace under research/rescan/before-after-loop2.md and evidence/rescan/loop2/.
Leave this PR unmerged for owner review.