revert: WebTransport spike + dep off master (restore stdlib+quic-go invariant) - #62
Merged
Conversation
The spike (PR #59) merged its webtransport-go dependency (+ transitive httpsfv) and ~250 LOC into every kernel binary while its own measurement showed it unjustified — the reliable path sustains ~61 Hz p95 and the Phase-5 gate stands. This broke the "stdlib + quic-go family only" invariant for a proven-unneeded pipe. Per the t260 hardening review: - deleted internal/transport/webtransport.go, devcert.go, webtransport_test.go - removed the --wt-addr flag + startup block from cmd/moos/main.go - go mod tidy dropped webtransport-go v0.10.0 + httpsfv v1.1.0 (go.mod back to quic-go + qpack + golang.org/x/*) - docs/spike-p9-webtransport.md retained with a REVERTED banner; the spike is preserved in git history and on the feat/webtransport branch - CLAUDE.md flag table + conventions updated go build/vet/test ./... all green. authored-by: agent:claude-cowork.hp-z440 / session:sam.z440-cowork-workspace / t260-security-hardening
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the P9 WebTransport/HTTP-3 datagram spike from master to restore the “stdlib + quic-go family only” dependency invariant for the kernel runtime.
Changes:
- Removed the WebTransport spike listener implementation, its dev-cert helper, and its associated tests.
- Removed the
--wt-addrflag and startup path fromcmd/moos/main.go. - Ran
go mod tidyto dropwebtransport-goand transitivehttpsfv; updated docs/CLAUDE.md to record the revert.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/transport/webtransport.go | Deleted the P9 WebTransport datagram spike server implementation. |
| internal/transport/webtransport_test.go | Deleted spike-specific loopback and isolation tests. |
| internal/transport/devcert.go | Deleted spike-only ephemeral TLS cert helper. |
| cmd/moos/main.go | Removed --wt-addr flag and WebTransport listener startup block. |
| go.mod | Dropped webtransport-go (and direct require block), returning to quic-go only. |
| go.sum | Removed checksums for webtransport-go and transitive httpsfv. |
| docs/spike-p9-webtransport.md | Added “REVERTED off master” banner while retaining spike record. |
| CLAUDE.md | Updated flag table and dependency invariant notes to reflect the revert. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+9
to
+11
| > invariant. This doc is retained as the record; the code lives in git history | ||
| > and on the `feat/webtransport` branch. Re-land only behind a real high-rate | ||
| > producer and a re-measurement that beats the reliable baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P1 from the t260 review — your call, since you merged #59 deliberately.
PR #59 shipped the
webtransport-godep (+ transitivehttpsfv) and ~250 LOC into every kernel binary, while the spike'''s own measurement showed it unjustified (reliable path ~61 Hz p95, Phase-5 gate stands). That broke the "stdlib + quic-go family only" invariant for a proven-unneeded pipe, off-by-default flag notwithstanding — a dep ingo.modis compiled in regardless of the flag.What changed
webtransport.go,devcert.go,webtransport_test.go; removed the--wt-addrflag + startup block.go mod tidydroppedwebtransport-go+httpsfv—go.modback toquic-go+qpack+golang.org/x/*.docs/spike-p9-webtransport.mdkept with a REVERTED banner; spike preserved in git history + thefeat/webtransportbranch (nothing lost).go build/vet/test ./...green.If you'd rather keep the spike on master, close this — it'''s cleanly reversible either way. Not auto-merged.
authored-by: agent:claude-cowork.hp-z440 / session:sam.z440-cowork-workspace / t260-security-hardening
🤖 Generated with Claude Code