fix(store): stop consecutive block/star toggles from racing - #16
Merged
Merged
Conversation
Optimistic flag updates after IPC, ignore in-flight toggles per problem, and coalesce reloads/auto-exports so rapid multi-row clicks cannot clobber.
Release the per-id guard after optimistic patch so same-id undo is not held through coalesced reload/export. Drop the sync-fail comment.
tomtom-bot40
approved these changes
Sep 16, 2026
tomtom-bot40
left a comment
There was a problem hiding this comment.
Standards
PASS on tip 2797ff8 — sync-fail comment removed (prior hard AGENTS nit cleared). Remaining block/star / coalesce duplication is judgement only.
Spec
PASS — multi-id consecutive unblock exit met; inFlight now ends after IPC+patch so same-id undo is not held through coalesce/export.
Totals: Standards 0 hard · Spec 0 blockers. Notes from 57b0391 addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rapid consecutive unblock/block (and star) clicks on the home list used stale row flags and awaited full reload + auto-export with no optimistic update, so later load/export could clobber newer DB state.
maybeAutoExportTest plan
pnpm typecheckcleanAddressed bot40 two-axis on
57b0391: removed sync-fail comment; narrowed inFlight. Tip2797ff8.