Repository navigation
SqlServer: fix the restore on main with System.Security.Cryptography.Pkcs 10.0.13 - #70
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The patched package exists, supports every targeted framework, and addresses the cited advisories.
0 open findings
What changed in this PR
Updates the SQL Server provider to override vulnerable transitive cryptography dependencies.
Changes:
- References patched
System.Security.Cryptography.Pkcs10.0.13 centrally. - Bumps the SQL Server provider version to 1.0.1.
| File | Description |
|---|---|
MEVD/src/SqlServer/SqlServer.csproj |
Adds the direct dependency and bumps the provider version. |
Directory.Packages.props |
Defines the patched dependency version. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
adamsitnik
approved these changes
Oct 14, 2026
adamsitnik
left a comment
adamsitnik
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thank you for the fix @Laurianti !
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since d479b99 the unit tests on Windows fail on
main(run): restoring SqlServer gives NU1902 and NU1903, as errors, forSystem.Security.Cryptography.Pkcs9.0.11 and 8.0.1, which Microsoft.Data.SqlClient brings. The advisories GHSA-846f-f764-76mx (high) and GHSA-2fmv-rv2c-59x7 (moderate) came out on 13 October. Microsoft.Data.SqlClient 6.1.7 still brings the same versions.Fix
System.Security.Cryptography.Pkcs10.0.13, the patched version, on every target.Tests
MEVD.slnfbuilds with no warnings and the SqlServer unit tests pass.