Repository navigation
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1621Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1621" |
afscrome
force-pushed
the
afscrome-replace-0000-with-ipv4host
branch
from
October 10, 2026 08:58
f3e485b to
3468b93
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use structured endpoint properties and caller-aware resolution across hosting integrations, and update endpoint allocation tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…ing integrations Adds the idiomatic host-port configuration pattern (matching Adminer, DbGate, Elasticvue, etc.) to every AddXyz() extension that takes a port parameter but was missing a matching fluent helper: ActiveMQ, Azure.DataApiBuilder, Flagd, Floci (Aws/Azure/Gcp), GoFeatureFlag, K3s, KurrentDB, LavinMQ, Listmonk, Logto, MailPit, McpInspector, Meilisearch, Mosquitto, Ngrok, Ollama, PapercutSmtp, Posta, RavenDB, RustFs, Sftp, Solr, StableDiffusionCpp, SurrealDb, Umami, Zitadel, and k6. Single-endpoint resources get WithHostPort(); multi-endpoint resources get With<EndpointName>HostPort() for each endpoint (e.g. WithAmqpHostPort, WithManagementHostPort, WithAdminHostPort, WithSmtpHostPort). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use endpoint properties for RustFS bind addresses and fake endpoint allocations in unit tests so endpoint resolution remains deterministic without reverting the endpoint-refactor behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
afscrome
force-pushed
the
afscrome-replace-0000-with-ipv4host
branch
from
October 10, 2026 09:11
3468b93 to
1787e1d
Compare
Contributor
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Endpoints to configure hosts / ports
Updated various community toolkit resources to use endpoints rather than hardcoding
host.docker.internal.Not using endpoints meant that many integrations had to build their own logic up around whether being consumed form a container or not. It also meant they were inconsistent over whether they used static/dynamic ports by default, or what the default port binding is.
Some of this is historic as the apis required to do this cleanly were a complex or even unavaialble to use until 13.1 and 13.2:
(Note, this may result in some breaking changes as resources may now bind to
127.0.0.1rather than0.0.0.0). Any such occurrences can be mitigated via.WithEndpoint(name, x => x.TargetHost = "0.0.0.0")Implemented
WithHostPort()pattern for configuring static portsA general pattern in aspire for ports is to default to a random port, and provide a
WithHostPort()method to allow that port to be changed. Added theWithHostPort()methods where needed.Not included in this pr
WithSmtpRelayHost())