fix(review): 사주 CalDAV 오프라인 Python 의존성 추가 - #594
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the trusted, offline OpenCode coverage-evidence Python environment by adding a hash-pinned runtime dependency set needed to run ContextualWisdomLab/saju-caldav tests in a --network=none sandbox, while keeping the existing “install from trusted lock only” discipline.
Changes:
- Added a new contract test to ensure the newly trusted saju-caldav runtime dependencies are present as exact pins in the source requirements and are hash-locked in the generated lock file.
- Appended the required runtime dependency pins (bcrypt/FastAPI/HTTPX/iCalendar/korean-lunar-calendar) to
requirements-opencode-review-ci.txt. - Regenerated
requirements-opencode-review-ci-hashes.txtwith uv to include hashes for the expanded dependency closure.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_opencode_python_dependency_lock.py | Adds a contract test enforcing that specific saju-caldav runtime pins are present and hash-locked (and that lunar-python is not). |
| requirements-opencode-review-ci.txt | Adds the trusted runtime pins required for offline saju-caldav test collection/execution. |
| requirements-opencode-review-ci-hashes.txt | Regenerated uv lock with hashes for the expanded trusted dependency set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
543d82f to
533accd
Compare
|
Superseded by the consolidated #604 branch, whose stated integration scope includes this PR’s saju-caldav offline coverage dependency lock, pyasn1 security pin, and associated contract tests together with the current evidence-boundary changes. Closing this older component branch to keep one conflict-resolution and review path. |
자동 리뷰 증거 계약
요약
실패 근거
검증
Closes #593
Unblocks ContextualWisdomLab/saju-caldav#6