Skip to content

hotfix: Prefer NVIDIA NIM models in OpenCode review pool - #680

Merged
seonghobae merged 2 commits into
mainfrom
seonghobae/nvidia-nim-opencode-priority
Jul 31, 2026
Merged

hotfix: Prefer NVIDIA NIM models in OpenCode review pool#680
seonghobae merged 2 commits into
mainfrom
seonghobae/nvidia-nim-opencode-priority

Conversation

@seonghobae

@seonghobae seonghobae commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • OpenCode Agent failed to produce a usable review on Add Thurstone (1927) Case V paired-comparison scaling fast-mlsirm#290 (opencode-review skipped; no opencode-agent review body).
  • Add OpenAI-compatible nvidia-nim provider (https://integrate.api.nvidia.com/v1, NVIDIA_API_KEY).
  • Prioritize six NIM models at the front of OPENCODE_MODEL_CANDIDATES.
  • Skip nvidia-nim/* when NVIDIA_API_KEY is unset (same pattern as OpenRouter).
  • Document temporary hotfix bypass; does not permanently weaken Security Scan / trivy / osv.

Test plan

  • Structural: opencode.jsonc brace-balanced; candidates string includes nvidia-nim/...
  • Pool runner exports is_nvidia_nim_candidate + NVIDIA skip path
  • Org secret NVIDIA_API_KEY configured on ContextualWisdomLab
  • Re-dispatch OpenCode on fast-mlsirm#290 after merge

Hotfix note

Temporary permission bypass authorized for landing this central-repo recovery; permanent gate weaken is out of scope.

Summary by CodeRabbit

  • 새 기능

    • NVIDIA NIM 기반 AI 모델을 코드 검토와 진단에 우선 활용하도록 지원합니다.
    • NVIDIA, Meta, DeepSeek, Mistral, Google 등 다양한 모델 후보와 자동 대체 순서를 제공합니다.
    • 인증 정보가 없으면 사용 가능한 기존 모델로 자동 전환됩니다.
  • 문서

    • NVIDIA NIM 설정, 필요한 인증 정보, 임시 운영 정책 및 원상 복구 절차를 안내하는 문서를 추가했습니다.
  • 개선 사항

    • 기본 및 소형 검토 모델을 업데이트해 검토 품질과 안정성을 높였습니다.

OpenCode skipped usable reviews on fast-mlsirm PR #290+. Add an
OpenAI-compatible nvidia-nim provider, prioritize Nemotron/Llama NIM
candidates in OPENCODE_MODEL_CANDIDATES, skip when NVIDIA_API_KEY is
unset, and document the temporary hotfix bypass (no permanent security
gate weaken).
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 29 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3aa301a2-d174-4640-8710-7c7090b2ae29

📥 Commits

Reviewing files that changed from the base of the PR and between 634924b and cc4ed88.

📒 Files selected for processing (2)
  • .github/workflows/opencode-review-dispatch.yml
  • scripts/ci/test_strix_quick_gate.sh
📝 Walkthrough

Walkthrough

OpenCode에 NVIDIA NIM 제공자와 모델을 추가했습니다. 워크플로가 NVIDIA_API_KEY를 전달합니다. 키가 없으면 모델 풀이 NIM 후보를 건너뜁니다. 검증 스크립트가 새 후보와 순서를 확인합니다.

Changes

NVIDIA NIM OpenCode 통합

Layer / File(s) Summary
NVIDIA NIM 제공자 및 모델 설정
opencode.jsonc, docs/nvidia-nim-opencode-hotfix.md
기본 모델과 소형 모델을 NVIDIA NIM으로 변경했습니다. NVIDIA_API_KEY 인증과 여러 NVIDIA, Meta, DeepSeek, Mistral, Codestral, Gemma 모델을 등록했습니다. 운영 및 롤백 절차를 문서화했습니다.
워크플로 및 조건부 모델 라우팅
.github/workflows/opencode-review-dispatch.yml, scripts/ci/run_opencode_review_model_pool.sh
OpenCode 실행 단계에 NVIDIA_API_KEY를 전달했습니다. 모델 풀에 NVIDIA NIM 후보를 추가했습니다. 키가 없으면 해당 후보를 건너뜁니다.
모델 순서 검증 갱신
scripts/ci/test_strix_quick_gate.sh
fallback 목록, 모델 풀 순서, 리뷰 시작 모델 검증에 NVIDIA NIM 후보를 반영했습니다.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related issues

Possibly related PRs

Sequence Diagram(s)

sequenceDiagram
  participant GitHubActions
  participant ModelPool
  participant NVIDIA_NIM
  GitHubActions->>ModelPool: NVIDIA_API_KEY 및 모델 후보 전달
  ModelPool->>ModelPool: NVIDIA NIM 후보 확인
  alt 키가 설정됨
    ModelPool->>NVIDIA_NIM: 선택한 모델로 OpenCode 검토 실행
    NVIDIA_NIM-->>ModelPool: 검토 결과 반환
  else 키가 설정되지 않음
    ModelPool->>ModelPool: NVIDIA NIM 후보 건너뛰기
  end
Loading
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 OpenCode 검토 모델 풀에서 NVIDIA NIM 모델을 우선 사용하도록 변경한 핵심 내용을 정확하고 간결하게 설명합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch seonghobae/nvidia-nim-opencode-priority

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae enabled auto-merge (squash) July 31, 2026 10:37

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/opencode-review-dispatch.yml:
- Line 3962: Update the Prepare isolated OpenCode review workspace step so its
generated opencode.jsonc reuses the canonical nvidia-nim provider definition and
includes all six configured NIM models in enabled_providers. Add a fast
validation gate that fails when the generated configuration lacks nvidia-nim,
and avoid maintaining a separate provider definition in the workflow.

In `@opencode.jsonc`:
- Around line 3-4: Update the default-model assertions in
test_strix_quick_gate.sh to expect the NVIDIA NIM values configured by the model
and small_model settings in opencode.jsonc, replacing the previous github-models
expectations. Run bash scripts/ci/test_strix_quick_gate.sh to verify the quick
gate passes.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6e7fb3de-5969-4506-a7d4-ac30775e08a8

📥 Commits

Reviewing files that changed from the base of the PR and between 9762ebd and 634924b.

📒 Files selected for processing (5)
  • .github/workflows/opencode-review-dispatch.yml
  • docs/nvidia-nim-opencode-hotfix.md
  • opencode.jsonc
  • scripts/ci/run_opencode_review_model_pool.sh
  • scripts/ci/test_strix_quick_gate.sh

Comment thread .github/workflows/opencode-review-dispatch.yml
Comment thread opencode.jsonc
@opencode-agent
opencode-agent Bot disabled auto-merge July 31, 2026 10:40
@seonghobae

Copy link
Copy Markdown
Contributor Author

Hotfix landing note

OpenCode failed to produce a usable review on ContextualWisdomLab/fast-mlsirm#290 (opencode-review skipped). This PR prioritizes NVIDIA NIM models in the central OpenCode pool.

Authorized temporary bypass: merge-aid for this hotfix only. Does not weaken Security Scan / trivy / osv.

Org secret required after merge: NVIDIA_API_KEY.

Include the NIM provider in the generated isolated opencode.jsonc used by
the model pool (not only OPENCODE_MODEL_CANDIDATES), prefer NIM defaults,
fail fast if the generated config lacks NIM, and update quick-gate asserts.
@seonghobae
seonghobae merged commit 6c5f92a into main Jul 31, 2026
46 checks passed
@seonghobae
seonghobae deleted the seonghobae/nvidia-nim-opencode-priority branch July 31, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant