fix(review): expose cross-repository dispatch failures - #692
Conversation
|
Warning Review limit reached
Next review available in: 23 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughOpenCode 교차 저장소 워크플로가 읽기·상태·댓글 토큰을 분리합니다. 상태 게시 실패 시 exact-head App 가시성 영수증을 생성하거나 갱신합니다. 상태 결정 스크립트와 테스트가 댓글 증거, stale-head, 토큰 권한 경계를 검증합니다. ChangesOpenCode 상태 가시성
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant 중앙 워크플로
participant 대상 저장소 GitHub API
participant opencode_dispatch_status.py
participant 대상 PR 댓글
중앙 워크플로->>대상 저장소 GitHub API: PR·리뷰·댓글·현재 head 조회
대상 저장소 GitHub API-->>중앙 워크플로: 검증 증거 반환
중앙 워크플로->>opencode_dispatch_status.py: 상태 결과와 댓글 evidence 전달
opencode_dispatch_status.py-->>중앙 워크플로: 상태 결정과 visibility 영수증 반환
중앙 워크플로->>대상 저장소 GitHub API: 커밋 상태 게시 시도
중앙 워크플로->>대상 PR 댓글: exact-head 영수증 생성 또는 갱신
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Around line 36-39: Update the README description of receipt publication to
match add_visibility_receipt in opencode_dispatch_status.py: receipts are
published when the status is not successful or when comment_id is present,
including failed outcomes even if status publication succeeds. Remove the claim
that receipts are only upserted when the optional status capability is
unavailable.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 121c618c-0781-4895-898c-26b53ca7d496
📒 Files selected for processing (5)
.github/workflows/opencode-review-dispatch.ymlREADME.mdscripts/ci/opencode_dispatch_status.pytests/test_opencode_agent_contract.pytests/test_opencode_security_boundaries.py
|
@coderabbitai review |
✅ Action performedReview finished.
|
9020427 to
f92f0cb
Compare
f92f0cb to
878df54
Compare
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head878df54b7547eea0e9a140cb2ff2f3f9a480f02f. -
Head SHA:
878df54b7547eea0e9a140cb2ff2f3f9a480f02f -
Workflow run: 30837150166
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: opencode-review-dispatch.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: opencode-review-dispatch.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file: README.md"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file: README.md"]
R2 --> V2["required checks"]
Evidence --> S3["CI script: opencode_dispatch_status.py"]
S3 --> I3["review and security gate shell path"]
I3 --> R3["Review risk: CI script: opencode_dispatch_status.py"]
R3 --> V3["bash -n plus Strix self-test"]
Evidence --> S4["Test (2 files)"]
S4 --> I4["regression suite"]
I4 --> R4["Review risk: Test (2 files)"]
R4 --> V4["targeted test run"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: opencode-review-dispatch.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: opencode-review-dispatch.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file: README.md"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file: README.md"]
R2 --> V2["required checks"]
Evidence --> S3["CI script: opencode_dispatch_status.py"]
S3 --> I3["review and security gate shell path"]
I3 --> R3["Review risk: CI script: opencode_dispatch_status.py"]
R3 --> V3["bash -n plus Strix self-test"]
Evidence --> S4["Test (2 files)"]
S4 --> I4["regression suite"]
I4 --> R4["Review risk: Test (2 files)"]
R4 --> V4["targeted test run"]
|
Closes #691
Summary
REVIEW_TOOL_FAILUREreceipt when central review cannot produce a validated approval, including when status publication is unavailable or forbiddengithub.tokenpermission limits explicit in logs and documentationValidation
python3 -m pytest -q— 800 passedpython3 -m coverage report --show-missing --fail-under=100— 6450/6450, 100%python3 -m interrogate --fail-under=100 --quiet .— passedpython3 -m ruff check scripts/ci/opencode_dispatch_status.py tests/test_opencode_agent_contract.py tests/test_opencode_security_boundaries.py— passedactionlint -shellcheck= .github/workflows/opencode-review-dispatch.yml— passedgit diff --check— passedSummary by CodeRabbit