fix(ci): snapshot dependencies on default-branch pushes so dependency-review has a base - #746
Closed
seonghobae wants to merge 1 commit into
Closed
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update
.github/workflows/sbom-generation.ymlto:main,master, anddevelop, so default-branch commits publish dependency snapshots;github.shaas the final concurrency fallback instead ofgithub.ref;This clean replacement is stacked on #731 so it can be validated against the repaired central security/review baseline. It supersedes #736, whose branch could not be rebased safely through the connector.
Why
Dependency review compares base and head dependency graphs. Without a default-branch dependency snapshot, the action sees zero base snapshots and treats the whole dependency set as newly added, repeatedly re-reporting pre-existing findings. The push trigger restores the intended diff-scoped semantics without weakening whole-repository scanners.
github.shais required for push events becausegithub.refwould put every push to one branch in the same cancel-in-progress group; a later push could cancel the earlier snapshot and recreate the missing-base defect.Verification contract
tests/test_sbom_generation_push_contract.pyproves:main,master, anddeveloppushes are included;dependency-snapshot: true;github.sha, nevergithub.ref;generate-sbomwith job-scopedcontents: write.Exact-current-head checks and independent approval remain mandatory. After #731 merges, this PR will be retargeted to
mainbefore merge.