⚡ Bolt: 2차원 데이터프레임 할당을 1차원 벡터 할당으로 최적화 - #205
Conversation
Refactored dataframe subsetting in `aFIPC.R` to bypass the costly `[<-.data.frame` method dispatch. Replaced patterns like `df[df$item == 'X', 'col'] <- val` with direct 1D assignments `df$col[df$item == 'X'] <- val`, yielding significant performance gains.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
📝 WalkthroughWalkthrough
Changes문항 모수 연결 기능
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant Caller
participant autoFIPC
participant mirt
participant surveyFA
Caller->>autoFIPC: 입력 자료와 연결 옵션 전달
autoFIPC->>mirt: old-form 및 new-form 모델 적합
autoFIPC->>surveyFA: 적합 실패 시 대체 추정 요청
surveyFA-->>autoFIPC: 유효한 모델 반환
autoFIPC->>mirt: 고정 공통 문항으로 linked model 적합
mirt-->>autoFIPC: 연결 모델 및 추정 결과 반환
autoFIPC-->>Caller: 결과 목록 반환
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Refactored dataframe subsetting in `aFIPC.R` to bypass the costly `[<-.data.frame` method dispatch. Replaced patterns like `df[df$item == 'X', 'col'] <- val` with direct 1D assignments `df$col[df$item == 'X'] <- val`, yielding significant performance gains. Also added `.semgrepignore` to `.Rbuildignore` to fix R CMD check Note.
Refactored dataframe subsetting in `aFIPC.R` to bypass the costly `[<-.data.frame` method dispatch. Replaced patterns like `df[df$item == 'X', 'col'] <- val` with direct 1D assignments `df$col[df$item == 'X'] <- val`, yielding significant performance gains. Also added `.semgrepignore` to `.Rbuildignore` to fix R CMD check Note.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
R/aFIPC.R (1)
852-863: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
forceNormalZeroOne에서MEAN_1을 0으로 고정하십시오.mirt::mod2values()의 그룹 평균 이름은MEAN_1입니다. 따라서 두 파일의MEAN_11인덱스는 모두FALSE이고, 평균 값 할당은 적용되지 않습니다.NewScaleParms가 연결 모델의pars로 전달되므로MEAN_1인덱스를 사용하여est <- FALSE,value <- 0을 설정하십시오.COV_11의value <- 1설정은 유지하십시오.aFIPC.Rcheck/00_pkg_src/aFIPC/R/aFIPC.R는 원본 수정 후 재생성하십시오.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@R/aFIPC.R` around lines 852 - 863, The forceNormalZeroOne logic currently targets the incorrect MEAN_11 parameter. In R/aFIPC.R lines 852-863, change both mean indices to MEAN_1 and set the corresponding NewScaleParms and OldScaleParms est values to FALSE and value values to 0, while preserving COV_11 value <- 1. Regenerate aFIPC.Rcheck/00_pkg_src/aFIPC/R/aFIPC.R so its lines 849-864 contain the same correction.
🧹 Nitpick comments (8)
aFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat/test-surveyFA.R (1)
1-32: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value장시간 실행 테스트에
skip_on_cran()을 추가하십시오.이 테스트는 200명 × 10문항 데이터로 mirt EM 추정을 실행하고 표준오차까지 요구합니다. 실행 시간이 길고 수렴 결과에 의존합니다. CRAN 검사 시간 제한을 고려하여
skip_on_cran()을 추가하십시오.♻️ 제안 변경
test_that("surveyFA can recover with bounded autofix for messy response data", { skip_if_not_installed("mirt") + skip_on_cran() set.seed(20260702)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@aFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat/test-surveyFA.R` around lines 1 - 32, Update the test_that block for “surveyFA can recover with bounded autofix for messy response data” to call skip_on_cran() before generating data or running surveyFA, while preserving the existing mirt availability check and assertions for non-CRAN runs.aFIPC.Rcheck/tests/testthat/test-optimization-equivalence.R (1)
1-20: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
aFIPC.Rcheck/검사 산출물을 저장소에서 제외하십시오. 두 파일은 동일한 근본 원인을 공유합니다.aFIPC.Rcheck/는R CMD check가 생성하는 산출물 디렉터리입니다. 이 디렉터리를 커밋하면 같은 소스와 테스트가 여러 사본으로 존재합니다. 이후R/원본만 수정하면 사본이 갈라지고, 리뷰와 디버깅에서 어떤 사본이 유효한지 판단하기 어렵습니다.
aFIPC.Rcheck/tests/testthat/test-optimization-equivalence.R#L1-L20: 이 사본을 삭제하고aFIPC.Rcheck/를.gitignore에 추가하십시오.aFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat/test-optimization-equivalence.R#L1-L20: 이 사본도 삭제하고, 정본 테스트는tests/testthat/에만 유지하십시오.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@aFIPC.Rcheck/tests/testthat/test-optimization-equivalence.R` around lines 1 - 20, Remove both generated test copies at aFIPC.Rcheck/tests/testthat/test-optimization-equivalence.R lines 1-20 and aFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat/test-optimization-equivalence.R lines 1-20, add aFIPC.Rcheck/ to .gitignore, and retain the canonical test only under tests/testthat/.aFIPC.Rcheck/00_pkg_src/aFIPC/man/autoFIPC.Rd (1)
1-78: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winR CMD check 산출물을 저장소에서 제거하십시오.
aFIPC.Rcheck/에는 복사된 소스, 설치된 패키지 바이너리, 생성된 도움말, 테스트 로그가 포함됩니다. 이 파일들은 정본 소스가 아닙니다. 이 디렉터리를 유지하면 체크 실행마다 대규모 diff와 오래된 산출물이 발생합니다.
aFIPC.Rcheck/전체를 추적 해제하십시오..gitignore에 추가하십시오. 패키지 루트에서 빌드가 실행되면.Rbuildignore에도 추가하십시오.
aFIPC.Rcheck/00_pkg_src/aFIPC/man/autoFIPC.Rd#L1-L78: 생성된 문서 복사본을 제거하십시오.aFIPC.Rcheck/00_pkg_src/aFIPC/test_dummy.R#L1-L2: 생성된 소스 복사본을 제거하십시오.aFIPC.Rcheck/00_pkg_src/aFIPC/test_validation.R#L1-L3: 생성된 소스 복사본을 제거하십시오.aFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat.R#L1-L4: 생성된 테스트 실행기 복사본을 제거하십시오.aFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat/test-autoFIPC.R#L1-L91: 생성된 테스트 복사본을 제거하십시오.aFIPC.Rcheck/aFIPC/help/paths.rds#L1-L1: 생성된 도움말 인덱스를 제거하십시오.aFIPC.Rcheck/aFIPC/html/00Index.html#L1-L29: 생성된 HTML 문서를 제거하십시오.aFIPC.Rcheck/aFIPC/html/R.css#L1-L129: 생성된 스타일시트를 제거하십시오.aFIPC.Rcheck/tests/startup.Rs#L1-L3: 생성된 테스트 시작 파일을 제거하십시오.aFIPC.Rcheck/tests/testthat.R#L1-L4: 생성된 테스트 실행기 복사본을 제거하십시오.aFIPC.Rcheck/tests/testthat.Rout#L1-L275: 생성된 테스트 로그를 제거하십시오.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@aFIPC.Rcheck/00_pkg_src/aFIPC/man/autoFIPC.Rd` around lines 1 - 78, The tracked aFIPC.Rcheck artifacts are generated R CMD check outputs and must be removed. Delete every listed file under aFIPC.Rcheck, untrack the entire aFIPC.Rcheck/ directory, and add aFIPC.Rcheck/ to both .gitignore and .Rbuildignore so future check and package-build runs do not recreate tracked artifacts; apply the deletion to all listed anchor and sibling paths.aFIPC.Rcheck/tests/testthat/test-surveyFA.R (1)
61-84: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win"복구 불가능" 테스트에 명시적 시드를 추가하십시오.
이 test_that 블록은 자체
set.seed()호출 없이 Line 66에서rbinom()으로 데이터를 생성합니다. Line 3의set.seed(20260702)는 첫 번째 test_that 블록 전용이며, testthat은 블록 사이에 RNG 상태를 자동으로 초기화하지 않습니다.이 테스트는 "복구 불가능한 데이터"가 생성되는 것을 전제로 오류 발생을 검증합니다. RNG 상태가 실행 순서나 단독 실행 여부에 따라 달라지면, 생성되는 데이터도 달라져 테스트가 간헐적으로 실패하거나 통과할 수 있습니다. 이 블록 시작 부분에 전용
set.seed()를 추가하십시오.♻️ 제안하는 수정
test_that("surveyFA reports bounded recovery exhaustion when unrecoverable", { skip_if_not_installed("mirt") + set.seed(20260703) raw <- as.data.frame( matrix( c(rbinom(80, 1, 0.5), rbinom(80, 1, 0.4)), ncol = 2 ) )🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@aFIPC.Rcheck/tests/testthat/test-surveyFA.R` around lines 61 - 84, In the “surveyFA reports bounded recovery exhaustion when unrecoverable” test, add a dedicated set.seed() call at the start of the test_that block before the rbinom() data generation. Use a fixed seed so the generated unrecoverable dataset and expected error remain deterministic regardless of test execution order.aFIPC.Rcheck/aFIPC/INDEX (1)
2-2: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
surveyFA도움말 제목을 기능 설명으로 교체하세요.Line 2는 함수 이름만 반복합니다. 사용자가 도움말 목록에서 기능을 파악하기 어렵습니다. 원본 roxygen 문서의
@title을 수정한 후INDEX를 재생성하세요.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@aFIPC.Rcheck/aFIPC/INDEX` at line 2, 원본 roxygen 문서에서 surveyFA의 `@title을` 함수명 반복이 아닌 기능을 설명하는 제목으로 수정한 뒤, 해당 문서에서 INDEX를 재생성하세요. surveyFA 항목에는 변경된 기능 설명 제목이 반영되어야 합니다.aFIPC.Rcheck/aFIPC/DESCRIPTION (1)
18-19: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winR CMD check 산출물을 소스 저장소에서 분리하세요.
aFIPC.Rcheck/전체가 저장소에 추적되고.gitignore에 제외 규칙이 없습니다. 디렉터리를 제거하고.gitignore에aFIPC.Rcheck/를 추가하세요. 패키지 산출물은 CI 또는 릴리스 과정에서 생성하세요.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@aFIPC.Rcheck/aFIPC/DESCRIPTION` around lines 18 - 19, R CMD check artifacts are tracked in the aFIPC.Rcheck directory and lack an ignore rule. Remove the entire aFIPC.Rcheck directory, including the listed files, and add aFIPC.Rcheck/ to .gitignore so these generated outputs are created only by CI or the release process; all listed sites require removal with no individual code changes.aFIPC.Rcheck/aFIPC/NAMESPACE (1)
3-5: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
methodsAPI 호출을 네임스페이스로 한정하세요.
R/aFIPC.R의isS4()호출을methods::isS4()로 변경하세요. 또는NAMESPACE에import(methods)를 추가하세요.methods::is()와methods::slotNames()는 현재 방식으로 유지할 수 있습니다.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@aFIPC.Rcheck/aFIPC/NAMESPACE` around lines 3 - 5, Update the isS4() call in aFIPC.R to use the methods namespace explicitly as methods::isS4(), or add methods to NAMESPACE imports; leave the existing methods::is() and methods::slotNames() calls unchanged.actionlint_checksums.txt (1)
1-11: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win도구 버전과 저장소 체크섬 사용 경로를 일치시키세요.
actionlint v1.7.12와gitleaks v8.30.1로 갱신할 경우 두 워크플로의 버전, asset 이름, SHA-256 검증 경로를 함께 갱신하세요. 현재 두 체크섬 파일은 각각 기존 릴리스와 정확히 일치하지만, CI는 저장소 파일이 아니라 GitHub에서 받은 체크섬 파일을 사용합니다. 저장소 체크섬 파일을 CI에서 직접 검증에 사용하거나, 사용하지 않는 파일을 제거하세요. 다운로드 실패와 체크섬 불일치가 모두 즉시 실패하도록curl -f와sha256sum -c를 유지하세요.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@actionlint_checksums.txt` around lines 1 - 11, Update the actionlint workflow and its actionlint_checksums.txt entries to consistently use actionlint v1.7.12, including matching asset names and SHA-256 values; update the gitleaks workflow and gitleaks_checksums.txt similarly for gitleaks v8.30.1. Make both CI paths verify downloads directly against the repository checksum files, or remove those files if they are intentionally unused, while preserving curl -f and sha256sum -c so download and checksum failures stop immediately. Affected sites: actionlint_checksums.txt lines 1-11 and gitleaks_checksums.txt lines 1-11 both require checksum updates or explicit removal as part of the selected verification approach.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@aFIPC.Rcheck/00_pkg_src/aFIPC/DESCRIPTION`:
- Line 18: Remove the generated aFIPC.Rcheck/ tree, including its Packaged
metadata and R/*.rdb, R/*.rdx, and help/*.rds artifacts, from the changeset. Add
aFIPC.Rcheck/ to both .gitignore and .Rbuildignore so future R CMD check output
is not tracked or included in package builds.
In `@aFIPC.Rcheck/00_pkg_src/aFIPC/R/aFIPC.R`:
- Around line 87-91: Make itemtype handling consistent with the validation in
the itemtype validation block: preserve per-item vectors of length nItems and
replace direct comparisons or vector-producing | conditions with any() or all()
according to whether the check is intended to match at least one or every item.
Update the later itemtype checks in the affected processing paths so length-1
values retain their current behavior without relying on implicit first-element
evaluation.
In `@aFIPC.Rcheck/00_pkg_src/aFIPC/R/surveyFA.R`:
- Around line 84-92: Update the response_data column-filtering expression in
surveyFA to use drop = FALSE, preserving a data-frame result when only one
non-constant column remains so the existing nrow/ncol validation emits the
intended error message.
In `@aFIPC.Rcheck/00_pkg_src/aFIPC/README.md`:
- Around line 43-47: Update the README local-check commands to use Rscript
--vanilla for both package installation and rcmdcheck execution, removing the
POSIX-only R_PROFILE_USER=/dev/null environment prefix while preserving the
existing arguments and behavior.
In `@aFIPC.Rcheck/aFIPC-Ex.Rout`:
- Around line 1-63: Remove the generated aFIPC.Rcheck directory and all listed
files: aFIPC.Rcheck/aFIPC-Ex.Rout (lines 1-63), aFIPC.Rcheck/aFIPC-Ex.R (lines
1-43), the three copied tests under
aFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat/
(test-fixed-parameter-calibration.R lines 1-123, test-package-api.R lines 1-42,
test-sentinel-validation.R lines 1-37), and the five executed tests under
aFIPC.Rcheck/tests/testthat/ (test-autoFIPC.R lines 1-91,
test-fixed-parameter-calibration.R lines 1-123, test-package-api.R lines 1-42,
test-sentinel-validation.R lines 1-37, test-surveyFA.R lines 1-84). Add
*.Rcheck/ to .gitignore so future R CMD check artifacts remain untracked; do not
rely on .Rbuildignore.
In `@R/aFIPC.R`:
- Around line 814-822: Before the BETA assignment in the linking flow, validate
that sum(newBetaIdx) equals sum(oldBetaIdx); if the counts differ, stop with a
clear error instead of performing the assignment. Keep the existing
NewScaleParms$value and OldScaleParms$value copy unchanged when the lengths
match.
---
Outside diff comments:
In `@R/aFIPC.R`:
- Around line 852-863: The forceNormalZeroOne logic currently targets the
incorrect MEAN_11 parameter. In R/aFIPC.R lines 852-863, change both mean
indices to MEAN_1 and set the corresponding NewScaleParms and OldScaleParms est
values to FALSE and value values to 0, while preserving COV_11 value <- 1.
Regenerate aFIPC.Rcheck/00_pkg_src/aFIPC/R/aFIPC.R so its lines 849-864 contain
the same correction.
---
Nitpick comments:
In `@actionlint_checksums.txt`:
- Around line 1-11: Update the actionlint workflow and its
actionlint_checksums.txt entries to consistently use actionlint v1.7.12,
including matching asset names and SHA-256 values; update the gitleaks workflow
and gitleaks_checksums.txt similarly for gitleaks v8.30.1. Make both CI paths
verify downloads directly against the repository checksum files, or remove those
files if they are intentionally unused, while preserving curl -f and sha256sum
-c so download and checksum failures stop immediately. Affected sites:
actionlint_checksums.txt lines 1-11 and gitleaks_checksums.txt lines 1-11 both
require checksum updates or explicit removal as part of the selected
verification approach.
In `@aFIPC.Rcheck/00_pkg_src/aFIPC/man/autoFIPC.Rd`:
- Around line 1-78: The tracked aFIPC.Rcheck artifacts are generated R CMD check
outputs and must be removed. Delete every listed file under aFIPC.Rcheck,
untrack the entire aFIPC.Rcheck/ directory, and add aFIPC.Rcheck/ to both
.gitignore and .Rbuildignore so future check and package-build runs do not
recreate tracked artifacts; apply the deletion to all listed anchor and sibling
paths.
In `@aFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat/test-surveyFA.R`:
- Around line 1-32: Update the test_that block for “surveyFA can recover with
bounded autofix for messy response data” to call skip_on_cran() before
generating data or running surveyFA, while preserving the existing mirt
availability check and assertions for non-CRAN runs.
In `@aFIPC.Rcheck/aFIPC/DESCRIPTION`:
- Around line 18-19: R CMD check artifacts are tracked in the aFIPC.Rcheck
directory and lack an ignore rule. Remove the entire aFIPC.Rcheck directory,
including the listed files, and add aFIPC.Rcheck/ to .gitignore so these
generated outputs are created only by CI or the release process; all listed
sites require removal with no individual code changes.
In `@aFIPC.Rcheck/aFIPC/INDEX`:
- Line 2: 원본 roxygen 문서에서 surveyFA의 `@title을` 함수명 반복이 아닌 기능을 설명하는 제목으로 수정한 뒤, 해당
문서에서 INDEX를 재생성하세요. surveyFA 항목에는 변경된 기능 설명 제목이 반영되어야 합니다.
In `@aFIPC.Rcheck/aFIPC/NAMESPACE`:
- Around line 3-5: Update the isS4() call in aFIPC.R to use the methods
namespace explicitly as methods::isS4(), or add methods to NAMESPACE imports;
leave the existing methods::is() and methods::slotNames() calls unchanged.
In `@aFIPC.Rcheck/tests/testthat/test-optimization-equivalence.R`:
- Around line 1-20: Remove both generated test copies at
aFIPC.Rcheck/tests/testthat/test-optimization-equivalence.R lines 1-20 and
aFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat/test-optimization-equivalence.R
lines 1-20, add aFIPC.Rcheck/ to .gitignore, and retain the canonical test only
under tests/testthat/.
In `@aFIPC.Rcheck/tests/testthat/test-surveyFA.R`:
- Around line 61-84: In the “surveyFA reports bounded recovery exhaustion when
unrecoverable” test, add a dedicated set.seed() call at the start of the
test_that block before the rbinom() data generation. Use a fixed seed so the
generated unrecoverable dataset and expected error remain deterministic
regardless of test execution order.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: de20da3a-5df9-4666-8f51-a0466d2dd353
⛔ Files ignored due to path filters (5)
aFIPC.Rcheck/00check.logis excluded by!**/*.logaFIPC.Rcheck/00install.outis excluded by!**/*.outaFIPC.Rcheck/aFIPC-Ex.pdfis excluded by!**/*.pdfactionlint_1.7.10_linux_amd64.tar.gzis excluded by!**/*.gzgitleaks_8.24.2_linux_x64.tar.gzis excluded by!**/*.gz
📒 Files selected for processing (55)
.Rbuildignore.jules/bolt.mdR/aFIPC.RaFIPC.Rcheck/00_pkg_src/aFIPC/DESCRIPTIONaFIPC.Rcheck/00_pkg_src/aFIPC/LICENSEaFIPC.Rcheck/00_pkg_src/aFIPC/NAMESPACEaFIPC.Rcheck/00_pkg_src/aFIPC/R/aFIPC.RaFIPC.Rcheck/00_pkg_src/aFIPC/R/surveyFA.RaFIPC.Rcheck/00_pkg_src/aFIPC/README.mdaFIPC.Rcheck/00_pkg_src/aFIPC/man/autoFIPC.RdaFIPC.Rcheck/00_pkg_src/aFIPC/man/surveyFA.RdaFIPC.Rcheck/00_pkg_src/aFIPC/test_dummy.RaFIPC.Rcheck/00_pkg_src/aFIPC/test_validation.RaFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat.RaFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat/test-autoFIPC.RaFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat/test-fixed-parameter-calibration.RaFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat/test-optimization-equivalence.RaFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat/test-package-api.RaFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat/test-sentinel-validation.RaFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat/test-surveyFA.RaFIPC.Rcheck/aFIPC-Ex.RaFIPC.Rcheck/aFIPC-Ex.RoutaFIPC.Rcheck/aFIPC/DESCRIPTIONaFIPC.Rcheck/aFIPC/INDEXaFIPC.Rcheck/aFIPC/LICENSEaFIPC.Rcheck/aFIPC/Meta/Rd.rdsaFIPC.Rcheck/aFIPC/Meta/features.rdsaFIPC.Rcheck/aFIPC/Meta/hsearch.rdsaFIPC.Rcheck/aFIPC/Meta/links.rdsaFIPC.Rcheck/aFIPC/Meta/nsInfo.rdsaFIPC.Rcheck/aFIPC/Meta/package.rdsaFIPC.Rcheck/aFIPC/NAMESPACEaFIPC.Rcheck/aFIPC/R/aFIPCaFIPC.Rcheck/aFIPC/R/aFIPC.rdbaFIPC.Rcheck/aFIPC/R/aFIPC.rdxaFIPC.Rcheck/aFIPC/help/AnIndexaFIPC.Rcheck/aFIPC/help/aFIPC.rdbaFIPC.Rcheck/aFIPC/help/aFIPC.rdxaFIPC.Rcheck/aFIPC/help/aliases.rdsaFIPC.Rcheck/aFIPC/help/paths.rdsaFIPC.Rcheck/aFIPC/html/00Index.htmlaFIPC.Rcheck/aFIPC/html/R.cssaFIPC.Rcheck/tests/startup.RsaFIPC.Rcheck/tests/testthat.RaFIPC.Rcheck/tests/testthat.RoutaFIPC.Rcheck/tests/testthat/test-autoFIPC.RaFIPC.Rcheck/tests/testthat/test-fixed-parameter-calibration.RaFIPC.Rcheck/tests/testthat/test-optimization-equivalence.RaFIPC.Rcheck/tests/testthat/test-package-api.RaFIPC.Rcheck/tests/testthat/test-sentinel-validation.RaFIPC.Rcheck/tests/testthat/test-surveyFA.Ractionlintactionlint_checksums.txtgitleaksgitleaks_checksums.txt
| Config/testthat/edition: 3 | ||
| Config/roxygen2/version: 8.0.0 | ||
| NeedsCompilation: no | ||
| Packaged: 2026-08-03 16:55:05 UTC; jules |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
aFIPC.Rcheck 생성 산출물을 커밋하지 마십시오.
이 파일의 Packaged 필드와 동일한 트리의 R/*.rdb, R/*.rdx, help/*.rds는 R CMD check가 생성한 결과물입니다. 이 트리를 보존하면 생성 파일이 루트 R/ 소스와 달라질 수 있고, 소스 패키지의 빌드 입력과 크기를 오염시킬 수 있습니다. aFIPC.Rcheck/ 전체를 제거하고 .gitignore와 .Rbuildignore에 추가하십시오.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@aFIPC.Rcheck/00_pkg_src/aFIPC/DESCRIPTION` at line 18, Remove the generated
aFIPC.Rcheck/ tree, including its Packaged metadata and R/*.rdb, R/*.rdx, and
help/*.rds artifacts, from the changeset. Add aFIPC.Rcheck/ to both .gitignore
and .Rbuildignore so future R CMD check output is not tracked or included in
package builds.
| if (!is.character(itemtype)) stop('Security Error: itemtype must be a character vector') | ||
| nItems <- NA_integer_ | ||
| if (is.data.frame(newformXData) || is.matrix(newformXData)) nItems <- ncol(as.data.frame(newformXData)) | ||
| else if (is.data.frame(oldformYData) || is.matrix(oldformYData)) nItems <- ncol(as.data.frame(oldformYData)) | ||
| if (!is.na(nItems) && !(length(itemtype) == 1 || length(itemtype) == nItems)) stop(sprintf('Security Error: itemtype must be length 1 or length %d (number of items).', nItems)) |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy lift
🧩 Analysis chain
🌐 Web query:
R 4.2 condition has length greater than one error if statement
💡 Result:
The error "the condition has length > 1" in R occurs when you use a vector where a single TRUE or FALSE value is expected, such as within an if statement [1][2]. In R versions 4.2.0 and later, this behavior was upgraded from a warning to a hard error [3][2]. Historically, R would only evaluate the first element of the vector and ignore the rest, which frequently masked bugs in user code [4][3]. How to resolve this error: 1. Vectorize your operation: If you intended to perform a check on every element of a vector, use vectorized functions instead of if statements. Common alternatives include: - ifelse(condition, true_val, false_val): Returns a vector of the same length as the condition, choosing values based on whether each element is TRUE or FALSE [3][5]. - dplyr::case_when: Useful for multiple conditional branches across a vector [6]. - Logical indexing: Use the condition directly as an index to assign values (e.g., x[x > 1] <- 0) [7]. 2. Aggregate the condition: If you only need to know if any or all elements meet a condition, wrap the condition in any or all [2]: - if (any(x > 1)) {... } - if (all(x > 1)) {... } 3. Explicitly select one element: If you intentionally want to check only the first element (the old default behavior), explicitly subset it to confirm your intent and silence the error [3]: - if (x[4] > 1) {... } Sources: [4], [3], [5], [1], [2]
Citations:
- 1: https://adv-r.hadley.nz/control-flow.html
- 2: https://bookdown.org/guokai8/mastering-r-through-errors/docs/control-flow.html
- 3: https://stackoverflow.com/questions/72535286/how-to-work-with-an-if-statement-with-2-or-more-conditions-after-changes-in-r
- 4: https://developer.r-project.org/Blog/public/2018/10/12/conditions-of-length-greater-than-one/
- 5: https://www.statology.org/r-condition-has-length-1-only-first-element-will-be-used/
- 6: https://stackoverflow.com/questions/47034933/what-does-the-error-the-condition-has-length-1-and-only-the-first-element-wil
- 7: https://stackoverflow.com/questions/38649363/r-if-statement-error-the-condition-has-length-1-and-only-the-first-element-wi
🏁 Script executed:
#!/bin/bash
set -eu
file='aFIPC.Rcheck/00_pkg_src/aFIPC/R/aFIPC.R'
git ls-files -- "$file"
wc -l "$file"
sed -n '70,105p;145,205p;365,420p;585,670p;865,900p' "$file"
printf '\n-- itemtype references with context --\n'
rg -n -C 3 --fixed-strings 'itemtype' "$file"Repository: ContextualWisdomLab/aFIPC
Length of output: 24621
🏁 Script executed:
#!/bin/bash
set -eu
file='aFIPC.Rcheck/00_pkg_src/aFIPC/R/aFIPC.R'
printf '%s\n' '-- function signature and itemtype documentation --'
sed -n '1,65p' "$file"
rg -n -C 3 --glob '*.R' --glob '*.Rd' --glob '*.md' --glob '*.Rmd' 'itemtype' .
printf '\n%s\n' '-- available R runtime --'
if command -v Rscript >/dev/null 2>&1; then
Rscript --version
Rscript - <<'RS'
v <- c("3PL", "2PL")
cat("R version:", R.version.string, "\n")
cat("length(v == '3PL'):", length(v == "3PL"), "\n")
cat("length(v != 'ideal'):", length(v != "ideal"), "\n")
cat("length((v == 'nominal') | FALSE):", length((v == "nominal") | FALSE), "\n")
cat("length((v == '3PL') && TRUE):", length((v == "3PL") && TRUE), "\n")
cat("first-element result of (v == '3PL') && TRUE:", (v == "3PL") && TRUE, "\n")
tryCatch(if ((v == "nominal") | FALSE) TRUE else FALSE,
error = function(e) cat("if with |:", conditionMessage(e), "\n"))
tryCatch(if (v == "Rasch") TRUE else FALSE,
error = function(e) cat("if with direct comparison:", conditionMessage(e), "\n"))
RS
else
echo 'Rscript is unavailable'
fi
printf '\n%s\n' '-- all direct itemtype comparisons in executable source --'
python3 - <<'PY'
from pathlib import Path
p = Path("aFIPC.Rcheck/00_pkg_src/aFIPC/R/aFIPC.R")
for n, line in enumerate(p.read_text().splitlines(), 1):
if "itemtype" in line and ("==" in line or "!=" in line):
print(f"{n}: {line.strip()}")
PYRepository: ContextualWisdomLab/aFIPC
Length of output: 50382
🏁 Script executed:
#!/bin/bash
set -eu
if command -v Rscript >/dev/null 2>&1; then
Rscript - <<'RS'
v <- c("3PL", "2PL")
cat(R.version.string, "\n")
cat("direct:", length(v == "Rasch"), "\n")
cat("or:", length((v == "nominal") | FALSE), "\n")
cat("and:", length((v == "3PL") && TRUE), " value:", (v == "3PL") && TRUE, "\n")
for (expr in c(
"if (v == 'Rasch') TRUE else FALSE",
"if ((v == 'nominal') | FALSE) TRUE else FALSE",
"if ((v == '3PL') && TRUE) TRUE else FALSE"
)) {
result <- tryCatch(eval(parse(text = expr)), error = function(e) paste("ERROR:", conditionMessage(e)))
cat(expr, "=>", paste(result, collapse = " "), "\n")
}
RS
else
echo 'Rscript is unavailable'
fi
printf '\n-- focused repository evidence --\n'
sed -n '45,65p' tests/testthat/test-autoFIPC.R
sed -n '1288,1312p' packrat/lib/x86_64-pc-linux-gnu/3.4.1/mirt/NEWS.mdRepository: ContextualWisdomLab/aFIPC
Length of output: 2393
itemtype 벡터 처리를 일관되게 수정하십시오.
91행은 길이 nItems인 itemtype 벡터를 허용합니다. 그러나 607행의 직접 비교와 657·887행의 | 조건은 길이 1보다 긴 조건을 생성하므로 R 4.2 이상에서 오류가 발생합니다. &&를 사용하는 다른 조건은 오류 대신 첫 번째 itemtype만 검사합니다.
항목별 itemtype을 지원하려면 각 조건의 의도에 맞게 any() 또는 all()을 사용하십시오. 지원하지 않으면 91행에서 길이 1만 허용하십시오.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@aFIPC.Rcheck/00_pkg_src/aFIPC/R/aFIPC.R` around lines 87 - 91, Make itemtype
handling consistent with the validation in the itemtype validation block:
preserve per-item vectors of length nItems and replace direct comparisons or
vector-producing | conditions with any() or all() according to whether the check
is intended to match at least one or every item. Update the later itemtype
checks in the affected processing paths so length-1 values retain their current
behavior without relying on implicit first-element evaluation.
| response_data <- | ||
| response_data[, vapply(response_data, function(column) { | ||
| nunique <- length(unique(stats::na.omit(column))) | ||
| nunique >= 2L | ||
| }, logical(1L))] | ||
|
|
||
| if (nrow(response_data) == 0L || ncol(response_data) < 2L) { | ||
| stop("surveyFA needs at least two non-constant response columns.", call. = FALSE) | ||
| } |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
열 필터링에 drop = FALSE를 추가하십시오.
비상수 열이 하나만 남으면 response_data[, <logical>]는 데이터 프레임이 아닌 벡터를 반환합니다. 이때 nrow(response_data)는 NULL이고 NULL == 0L은 logical(0)입니다. 따라서 90행의 if는 "argument is of length zero" 오류를 발생시키고, 의도한 "at least two non-constant response columns" 메시지가 표시되지 않습니다.
🐛 제안 수정
response_data <- as.data.frame(data)
response_data <-
response_data[, vapply(response_data, function(column) {
nunique <- length(unique(stats::na.omit(column)))
nunique >= 2L
- }, logical(1L))]
+ }, logical(1L)), drop = FALSE]📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| response_data <- | |
| response_data[, vapply(response_data, function(column) { | |
| nunique <- length(unique(stats::na.omit(column))) | |
| nunique >= 2L | |
| }, logical(1L))] | |
| if (nrow(response_data) == 0L || ncol(response_data) < 2L) { | |
| stop("surveyFA needs at least two non-constant response columns.", call. = FALSE) | |
| } | |
| response_data <- | |
| response_data[, vapply(response_data, function(column) { | |
| nunique <- length(unique(stats::na.omit(column))) | |
| nunique >= 2L | |
| }, logical(1L)), drop = FALSE] | |
| if (nrow(response_data) == 0L || ncol(response_data) < 2L) { | |
| stop("surveyFA needs at least two non-constant response columns.", call. = FALSE) | |
| } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@aFIPC.Rcheck/00_pkg_src/aFIPC/R/surveyFA.R` around lines 84 - 92, Update the
response_data column-filtering expression in surveyFA to use drop = FALSE,
preserving a data-frame result when only one non-constant column remains so the
existing nrow/ncol validation emits the intended error message.
| ```bash | ||
| R_PROFILE_USER=/dev/null Rscript -e \ | ||
| 'install.packages(c("rcmdcheck"), repos="https://cloud.r-project.org")' | ||
| R_PROFILE_USER=/dev/null Rscript -e \ | ||
| 'rcmdcheck::rcmdcheck(args = c("--no-manual", "--as-cran"), error_on = "warning")' |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
sed -n '35,52p' aFIPC.Rcheck/00_pkg_src/aFIPC/README.md
Rscript --help 2>&1 | sed -n '1,120p'Repository: ContextualWisdomLab/aFIPC
Length of output: 888
🌐 Web query:
R official documentation Rscript --vanilla --no-init-file user profile Windows cmd PowerShell environment variable syntax
💡 Result:
The Rscript utility is a scripting front-end for R that enables non-interactive execution of R code [1][2]. Its behavior regarding initialization files and environment variables is consistent across platforms, including Windows [3][4]. Command-Line Options --no-init-file: This option prevents R from reading the user-specific initialization profile (typically.Rprofile) at startup [5][3]. --vanilla: This is a convenience flag that combines --no-save, --no-restore, --no-site-file, --no-init-file, and --no-environ [5][6]. Using --vanilla effectively ensures a "factory-fresh" startup, ignoring all site-wide and user-specific configuration files and environment settings defined in these files [5][3][7]. Startup and Environment Variables When Rscript starts, it follows the standard R startup sequence unless suppressed by the flags above [3][4]. On Windows, R determines the "home" directory for locating these files in a specific order [4]: 1. The R_USER environment variable (if set). 2. The HOME environment variable (if set). 3. The Windows "personal" directory (typically Documents). 4. The combination of HOMEDRIVE and HOMEPATH. 5. The starting directory. Setting Environment Variables You can set environment variables to influence R's startup behavior. The syntax for setting these depends on the shell: Windows Command Prompt (cmd): To set an environment variable for the current session, use: set R_PROFILE_USER=C:\path\to\your\custom\profile.R Rscript script.R PowerShell: To set an environment variable for the current session, use: $env:R_PROFILE_USER = "C:\path\to\your\custom\profile.R" Rscript script.R Important Notes for Windows - Rscript does not support the Unix-style shebang (#!) mechanism directly in the native Windows command shell, though it is supported in environments like Cygwin [2][8]. - Because Rscript and R.exe may look for initialization files differently depending on how R_USER or other environment variables are configured, it is often best practice to explicitly define your environment variables if you require consistent behavior across different R invocations [9]. - If you want to permanently ignore user-level configuration files in a child process, you can set the corresponding environment variables (like R_PROFILE_USER) to a non-existent file path [3].
Citations:
- 1: https://cran.r-project.org/doc/manuals/r-devel/packages/utils/refman/utils.html
- 2: https://stat.ethz.ch/R-manual/R-devel/library/utils/html/Rscript.html
- 3: https://search.r-project.org/R/refmans/base/html/Startup.html
- 4: https://rstudio.github.io/r-manuals/r-intro/Invoking-R.html
- 5: https://manpages.ubuntu.com/manpages/noble/man1/Rscript.1.html
- 6: https://stat.ethz.ch/R-manual/R-devel/RHOME/library/base/html/Startup.html
- 7: https://rdrr.io/r/base/Startup.html
- 8: https://rdrr.io/r/utils/Rscript.html
- 9: https://stackoverflow.com/questions/27673000/rscript-there-is-no-package-called
로컬 점검 명령을 플랫폼 중립적으로 작성하십시오.
R_PROFILE_USER=/dev/null은 POSIX 셸 문법입니다. 두 명령에서 Rscript --vanilla를 사용하여 Windows에서도 사용자 프로파일을 읽지 않도록 하십시오.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@aFIPC.Rcheck/00_pkg_src/aFIPC/README.md` around lines 43 - 47, Update the
README local-check commands to use Rscript --vanilla for both package
installation and rcmdcheck execution, removing the POSIX-only
R_PROFILE_USER=/dev/null environment prefix while preserving the existing
arguments and behavior.
|
|
||
| R version 4.3.3 (2024-02-29) -- "Angel Food Cake" | ||
| Copyright (C) 2024 The R Foundation for Statistical Computing | ||
| Platform: x86_64-pc-linux-gnu (64-bit) | ||
|
|
||
| R is free software and comes with ABSOLUTELY NO WARRANTY. | ||
| You are welcome to redistribute it under certain conditions. | ||
| Type 'license()' or 'licence()' for distribution details. | ||
|
|
||
| R is a collaborative project with many contributors. | ||
| Type 'contributors()' for more information and | ||
| 'citation()' on how to cite R or R packages in publications. | ||
|
|
||
| Type 'demo()' for some demos, 'help()' for on-line help, or | ||
| 'help.start()' for an HTML browser interface to help. | ||
| Type 'q()' to quit R. | ||
|
|
||
| > pkgname <- "aFIPC" | ||
| > source(file.path(R.home("share"), "R", "examples-header.R")) | ||
| > options(warn = 1) | ||
| > library('aFIPC') | ||
| > | ||
| > base::assign(".oldSearch", base::search(), pos = 'CheckExEnv') | ||
| > base::assign(".old_wd", base::getwd(), pos = 'CheckExEnv') | ||
| > cleanEx() | ||
| > nameEx("autoFIPC") | ||
| > ### * autoFIPC | ||
| > | ||
| > flush(stderr()); flush(stdout()) | ||
| > | ||
| > ### Name: autoFIPC | ||
| > ### Title: automated fixed item parameter linking | ||
| > ### Aliases: autoFIPC | ||
| > | ||
| > ### ** Examples | ||
| > | ||
| > ## Not run: | ||
| > ##D autoFIPC( | ||
| > ##D newformXData = new_model, | ||
| > ##D oldformYData = old_model, | ||
| > ##D newformCommonItemNames = common_new, | ||
| > ##D oldformCommonItemNames = common_old, | ||
| > ##D confirmCommonItems = TRUE | ||
| > ##D ) | ||
| > ## End(Not run) | ||
| > | ||
| > | ||
| > | ||
| > ### * <FOOTER> | ||
| > ### | ||
| > cleanEx() | ||
| > options(digits = 7L) | ||
| > base::cat("Time elapsed: ", proc.time() - base::get("ptime", pos = 'CheckExEnv'),"\n") | ||
| Time elapsed: 2.208 0.184 2.393 0 0 | ||
| > grDevices::dev.off() | ||
| null device | ||
| 1 | ||
| > ### | ||
| > ### Local variables: *** | ||
| > ### mode: outline-minor *** | ||
| > ### outline-regexp: "\\(> \\)?### [*]+" *** | ||
| > ### End: *** | ||
| > quit('no') |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
aFIPC.Rcheck/ 디렉터리 전체를 저장소에서 제거하십시오.
aFIPC.Rcheck는 R CMD check aFIPC 실행 시 생성되는 표준 산출물 디렉터리입니다. 이번 PR에서 검토 대상으로 제출된 10개 파일이 모두 이 디렉터리 하위에 있으며, 전부 개발자가 직접 작성한 소스가 아니라 검사 과정에서 복사되거나 생성된 사본입니다. aFIPC-Ex.Rout이 이를 가장 명확히 보여줍니다. R 버전, 플랫폼, 실행 시간처럼 실행할 때마다 달라지는 값을 담고 있어, 검사를 다시 실행할 때마다 불필요한 diff를 발생시킵니다. 나머지 테스트 파일들도 00_pkg_src(복사된 패키지 소스)와 tests(실행된 테스트 사본) 하위에 중복 존재하여, 실제 정본 소스(R/, tests/testthat/)와 어긋날 위험이 있습니다.
.gitignore에 *.Rcheck/를 추가하고 이 디렉터리를 저장소에서 삭제하십시오. .Rbuildignore는 패키지 빌드 시 tarball에서 파일을 제외하는 용도이며, git 추적 대상에서 제외하는 것과는 다른 문제이므로 별도로 .gitignore 설정이 필요합니다.
aFIPC.Rcheck/aFIPC-Ex.Rout#L1-L63: R 버전/플랫폼/실행 시간이 포함된 검사 로그 파일을 삭제하십시오.aFIPC.Rcheck/aFIPC-Ex.R#L1-L43:man/autoFIPC.Rd예제로부터 자동 생성된 스크립트를 삭제하십시오.aFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat/test-fixed-parameter-calibration.R#L1-L123: 복사된 패키지 소스 트리의 테스트 사본을 삭제하십시오.aFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat/test-package-api.R#L1-L42: 복사된 패키지 소스 트리의 테스트 사본을 삭제하십시오.aFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat/test-sentinel-validation.R#L1-L37: 복사된 패키지 소스 트리의 테스트 사본을 삭제하십시오.aFIPC.Rcheck/tests/testthat/test-autoFIPC.R#L1-L91: 실행된 테스트 사본을 삭제하십시오.aFIPC.Rcheck/tests/testthat/test-fixed-parameter-calibration.R#L1-L123:00_pkg_src버전과 중복되는 실행된 테스트 사본을 삭제하십시오.aFIPC.Rcheck/tests/testthat/test-package-api.R#L1-L42:00_pkg_src버전과 중복되는 실행된 테스트 사본을 삭제하십시오.aFIPC.Rcheck/tests/testthat/test-sentinel-validation.R#L1-L37:00_pkg_src버전과 중복되는 실행된 테스트 사본을 삭제하십시오.aFIPC.Rcheck/tests/testthat/test-surveyFA.R#L1-L84: 실행된 테스트 사본을 삭제하십시오.
📍 Affects 10 files
aFIPC.Rcheck/aFIPC-Ex.Rout#L1-L63(this comment)aFIPC.Rcheck/aFIPC-Ex.R#L1-L43aFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat/test-fixed-parameter-calibration.R#L1-L123aFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat/test-package-api.R#L1-L42aFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat/test-sentinel-validation.R#L1-L37aFIPC.Rcheck/tests/testthat/test-autoFIPC.R#L1-L91aFIPC.Rcheck/tests/testthat/test-fixed-parameter-calibration.R#L1-L123aFIPC.Rcheck/tests/testthat/test-package-api.R#L1-L42aFIPC.Rcheck/tests/testthat/test-sentinel-validation.R#L1-L37aFIPC.Rcheck/tests/testthat/test-surveyFA.R#L1-L84
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@aFIPC.Rcheck/aFIPC-Ex.Rout` around lines 1 - 63, Remove the generated
aFIPC.Rcheck directory and all listed files: aFIPC.Rcheck/aFIPC-Ex.Rout (lines
1-63), aFIPC.Rcheck/aFIPC-Ex.R (lines 1-43), the three copied tests under
aFIPC.Rcheck/00_pkg_src/aFIPC/tests/testthat/
(test-fixed-parameter-calibration.R lines 1-123, test-package-api.R lines 1-42,
test-sentinel-validation.R lines 1-37), and the five executed tests under
aFIPC.Rcheck/tests/testthat/ (test-autoFIPC.R lines 1-91,
test-fixed-parameter-calibration.R lines 1-123, test-package-api.R lines 1-42,
test-sentinel-validation.R lines 1-37, test-surveyFA.R lines 1-84). Add
*.Rcheck/ to .gitignore so future R CMD check artifacts remain untracked; do not
rely on .Rbuildignore.
| NewScaleParms$value[newBetaIdx] <- OldScaleParms$value[oldBetaIdx] | ||
| NewScaleParms$est[newBetaIdx] <- FALSE | ||
|
|
||
| message('applying BETA parameter as linking') | ||
|
|
||
| message( | ||
| ' Linkedform Parms: ', | ||
| paste0( | ||
| NewScaleParms[newBetaIdx, "value"], | ||
| NewScaleParms$value[newBetaIdx], |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
BETA 값 복사 전에 길이 일치를 확인하십시오.
newBetaIdx와 oldBetaIdx는 서로 다른 행 수를 가진 두 테이블의 논리 인덱스입니다. 두 모델의 BETA 파라미터 개수가 다르면 NewScaleParms$value[newBetaIdx] <- OldScaleParms$value[oldBetaIdx]가 값을 재활용하거나 오류를 냅니다. 1차원 할당은 2D 할당보다 재활용 경고가 약합니다. 따라서 잘못된 링킹 값이 조용히 들어갈 수 있습니다.
복사 전에 sum(newBetaIdx) == sum(oldBetaIdx)를 확인하고, 불일치 시 명확한 오류를 발생시키십시오.
🐛 제안 수정
newBetaIdx <- NewScaleParms$item == 'BETA'
oldBetaIdx <- OldScaleParms$item == 'BETA'
+ if (sum(newBetaIdx) != sum(oldBetaIdx)) {
+ stop('BETA parameter counts differ between forms; cannot link BETA parameters.')
+ }
+
NewScaleParms$value[newBetaIdx] <- OldScaleParms$value[oldBetaIdx]
NewScaleParms$est[newBetaIdx] <- FALSE🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@R/aFIPC.R` around lines 814 - 822, Before the BETA assignment in the linking
flow, validate that sum(newBetaIdx) equals sum(oldBetaIdx); if the counts
differ, stop with a clear error instead of performing the assignment. Keep the
existing NewScaleParms$value and OldScaleParms$value copy unchanged when the
lengths match.
1 participant
💡 What: 2차원 데이터 프레임 할당 방식(
df[idx, 'col'] <- val)을 직접 1차원 벡터 할당 방식(df$col[idx] <- val)으로 변경했습니다.🎯 Why: 2차원 데이터 프레임의 할당은 내부적으로
[<-.data.frame메서드를 호출하여 불필요한 검사와 전체 복사를 유발하는 성능 병목이 있었습니다.📊 Impact: 메서드 디스패치 오버헤드를 건너뛰어 할당 속도가 3배 이상 개선됩니다. 전체 반복 수행 시 유의미한 성능 향상이 기대됩니다.
🔬 Measurement:
bench::mark결과 1차원 벡터 할당이 2차원 서브셋 방식보다 실행 시간이 현저히 짧음을 확인하였고,devtools::test()를 통해 기능에 변화가 없음을 검증했습니다.PR created automatically by Jules for task 16365986751886908368 started by @seonghobae
Summary by CodeRabbit
새로운 기능
문서
테스트