MILP trail search methods for one trail within a weight range - #492
Open
p-huynh wants to merge 1 commit into
Open
MILP trail search methods for one trail within a weight range #492p-huynh wants to merge 1 commit into
p-huynh wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Currently, the MILP xor differential/linear models only allow the user to find one optimal trail or one trail with an exact weight. This PR adds two new
find_one_xor_*_trail_with_weight_at_mostmethods:[0..upper_bound](or[lower_boud..upper_bound]), mirroring the existingfind_all_*_trails_with_weight_at_mostmethods.fixed weightmethods now just call these with the lower and upper bound set to the same value.Additional cleanup:
weight_constraints, and removed an old unused trick where a negative weight quietly meant "at most". It only existed in the MILP model and nothing used it.find_all_..._with_weight_at_mostto add a single range constraint and collect the trails in one pass, instead of looping over every weight value. It returns the same trails, with fewer solver calls.