Repository navigation
Protect and reclaim saved binary versions with retained reader leases - #102
Merged
Merged
Conversation
vanedaltro
marked this pull request as ready for review
November 2, 2026 12:28
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saved binary images need to remain available while a view or prepared save uses them, and expired history needs recoverable reclamation.
Add shared history leases for saved readers and prepared saves, bind saved views to every original source parent, and retire eligible saved versions to durable tombstones before reclaiming unreferenced images. Current and dirty bases, Last Save, checkpoint-protected versions, pending notifications, uncertain operations, and changed/unclassified stages remain protected. Cleanup rechecks cancellation and trusted authority before each namespace change and never changes source bytes.
Validation: 79 binary-core tests passed (one child helper ignored); core library/test Clippy and strict OpenSpec validation (114 items) passed. The rebase onto merged #101 has an identical source tree to the tested branch.
This provides the storage primitive. The seven-day retention/checkpoint adapter and remaining editor acceptance are follow-up work under #94; this PR does not close that issue.