Repository navigation
Fix two timing-dependent tests that fail CI on unrelated PRs - #118
Merged
Merged
Conversation
…time The binary worker returns its path permit before its activity scope drops and deregisters on the worker thread, so a single read of the registry right after shutdown could still see it on a loaded runner. Wait up to 5 s for it to empty, at both checks. reviewed_recovery_busy_confirmation_requires_interrupt_ack_and_a_new_review gave a background exec 10 s to reach the scripted model, which a loaded Windows runner can exceed (it failed main's Windows build and passed on others). Allow 60 s, as other Windows paths do, and report the exec's exit status and stderr if it ends first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two tests failed intermittently on unrelated PRs (#113, #115, #116), and one of them failed
main's own Windows build atdb9e171e. Both are test timing problems, not product bugs.disposed_binary_request_retains_worker_ownership_until_actual_exit(and its sibling check)The binary worker returns its path permit before its activity
Scopedrops. Dropping the scope is what removes the activity from the registry, and it happens on the worker's own thread. The test assertedavailable_permits() == 1and then readactivities.is_empty()once, so a loaded runner could still see the entry. The test now waits up to 5 s for the registry to empty (activities_drained), at both places it checked. The ownership guarantees under test are unchanged.reviewed_recovery_busy_confirmation_requires_interrupt_ack_and_a_new_review(Windows)The test starts a background
cyber exec … GATEand gave it 10 s to reach the scripted model. On a loaded Windows runner, starting exec and its first request can take longer. That failedmain's Windows build, while the same test passed on other runs (e.g. #117's).Tests
cargo nextest run --workspace --profile cion top of the currentmain(with Re-send failed Turns on the model fallback chain #115–Drive cyber exec over stdin with --input-format stream-json #117 merged): 5770 passed, 0 failed.-D warnings.Not addressed: a one-off Windows failure in
mcp_oauth::a_refresh_timeout_fires_during_a_blocked_write_which_keeps_the_lockseen once on #115; it passed on rerun.