Repository navigation
Test CwdChanged admission across failed idle-exit commits - #87
Merged
Merged
Conversation
Open
42 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CwdChanged acceptance covered successful moves, permission refusal, replay and shutdown, but lacked a direct hook assertion for a failed relocation append. Add a real-runtime/HTTP regression that enters a worktree, injects an append fault for that Session's idle exit, and verifies the original Location remains with no durable exit or CwdChanged delivery. Clear the fault and require one successful exit with matching durable transition identity; another exit must be silent.
The test proves the injected Store path was reached and includes positive delivery assertions, so disabling the producer cannot satisfy it. The injected failure occurs before append; unknown commit outcomes and the rest of producer task 5.3 remain open. No production behavior, schema or public API changes.
This increment is independent of PR #85's FileChanged alias tests and is based directly on main after PR #86.
Validation:
-D warnings.messages_cli::an_exec_session_refuses_messages_unless_it_accepts_themandparallel_workflows::three_runs_share_the_slots_fairly_and_are_controlled_independently; their causes are unverified.