Repository navigation
Test CwdChanged uncertainty and record FileChanged acceptance - #89
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A worktree relocation can commit its destination before the previous Location owner acknowledges settlement. The runtime must preserve that durable transition without emitting a successful CwdChanged observation when settlement is uncertain. Add a runtime/Store regression that compares acknowledged and unacknowledged settlement, verifies durable identity and hook suppression, requires recovery before further entry/idle-exit, and checks admission release without a delayed success hook after call completion and shutdown. The test uses a simulated lease owner; no production behavior, API, schema or native support floor changes.
Reconcile FileChanged acceptance after merged #85 and #88 in the same follow-up. Retain the final source-bound platform receipt and accepted-main composition, distinguish superseded historical receipts, and remove stale CI-pending ledger claims. The audit directly checks all 14 table regressions plus eight queue/lifetime/privacy/unknown-outcome cases in the actual Linux/macOS/Windows logs. Close only bounded FileChanged task 5.2; the full producer matrix, native enforcement/protocols, daily coding and binary editor remain open. Update delivery notes to this single active follow-up PR.
Verification:
cargo test -p cyber-server --test location_activity: all 12 cases passed on macOS.--no-deps -- -D warnings: passed.an unacknowledged transition emitted CwdChanged. Production source was restored, and the complete test target passed again.f7db7edbafter current-main integration and evidence consolidation. It is the only Rust/Cargo/configuration/workflow input changed against main.messages_cli::an_exec_session_refuses_messages_unless_it_accepts_them; cause unverified. Platform exclusions and intentional helper ignores are explicit in the receipt.Task 5.3 stays open. The new case does not prove native confinement or uncertain Store-commit handling. Explicit Linux support and Setup/DirectoryAdded design-review gates are preserved.
Final current-head acceptance: all 16 checks passed. The named new Location-settlement case actually executes and passes on Linux, macOS and Windows. Broad Linux/macOS each pass 5,505 cases (21/23 skipped); Windows passes 3,781 selected cases (648 skipped), metadata (4), migration (9) and AppContainer (18). Windows reports one leaked-process warning in the messaging case already identified above; its cause remains unverified. All actual checkout logs bind to
db443ee1e468e055fa040196948936eaff267afb, whose tree equals the reviewed head and current prospective merge. Source review found no blocking issue in the final nine-file diff. The full workstream and task 5.3 remain open.