fix: harden workbench units and usability - #6
Merged
Conversation
Owner
Author
Agent 审查总结
|
D-sudoasd
marked this pull request as ready for review
August 23, 2026 14:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scientific and data-integrity fixes
nm^-1toA^-1exactly once in CLI workflows, including safe explicit-column overridesNaNduring sector merging and exclude non-finite intensities from weightingUser-facing refinements
Verification
py -3.12 -m pytest -q— 975 passedpy -3.12 -m ruff check SASAbs.py src tests— passedpy -3.12 -m compileall -q src SASAbs.py— passedgit diff --check— passedValidation boundary
This is engineering and synthetic-data validation. No real beamline dataset was used, so it does not constitute scientific acceptance of an experimental calibration result.
本次 Agent 审查与改进
cac6efc2ad65a329221d0b32941d89629d635303id/index与I/cm选择、显式NaN和行内注释、依赖/容差预检、sector fallback 与文件扩展名提示。git diff --check通过;两名独立终审均为 CLEAR/APPROVE;PR head CI run3264435920213/13 项成功。0c03f9372ba2c222a60eeae3a41cad98d35af44d;合并提交的文件树与已验证 head 完全一致。mainCI run3264510376713/13 项成功。codex/fix-workbench-audit分支,均仍指向cac6efc2ad65a329221d0b32941d89629d635303。