L4: mapkeys — SC state key enumeration (fixes #108, stacks on #107) - #109
Closed
liqdmetal wants to merge 6 commits into
Closed
L4: mapkeys — SC state key enumeration (fixes #108, stacks on #107)#109liqdmetal wants to merge 6 commits into
liqdmetal wants to merge 6 commits into
Conversation
…F/ELSE/ENDIF
Replaces GOTO-only spaghetti with structured loops and blocks (spec
dero-improvements-agenda.md L1, P0). Halves contract size, cuts the
len(scdata)*1.5 code-size fee term, makes contracts auditable.
New dvm/control_flow.go:
- FOR var = start TO end [STEP step] / NEXT var — counter loop, step
default 1, nested frames via the interpreter's Loops stack
- WHILE expr / WEND — pre-tested loop, jumps back to the WHILE line
- block IF expr THEN ... [ELSE ...] ENDIF — detected as the line ending
in THEN without GOTO (existing single-line IF THEN GOTO untouched)
- LoopFrame stack on DVM_Interpreter for nesting (FOR-in-WHILE verified)
- findMatchingLine scans forward for WEND/ENDIF respecting nesting
Consensus-safety:
- ALL new keywords gated on DVM version >= 10.0.0 (contract must call
version("10.0.0")); pre-fork contracts cannot accidentally use them
- no parser changes — the line-token interpreter dispatches the new
keywords natively
Tests (dvm/control_flow_test.go, 8 cases):
- FOR/NEXT sum(1..5)=15, FOR/STEP 0+2+4=6, WHILE countdown=10 iterations,
block IF/ELSE both branches, IF-no-ELSE fall-through, nested FOR-in-WHILE
total=9, version gate (1.2.3 rejected), no-version gate (0.0.0 rejected)
Full dvm suite green, whole tree builds.
…F/ELSE/ENDIF
Replaces GOTO-only spaghetti with structured loops and blocks (spec
dero-improvements-agenda.md L1, P0). Halves contract size, cuts the
len(scdata)*1.5 code-size fee term, makes contracts auditable.
New dvm/control_flow.go:
- FOR var = start TO end [STEP step] / NEXT var — counter loop, step
default 1, nested frames via the interpreter's Loops stack
- WHILE expr / WEND — pre-tested loop, jumps back to the WHILE line
- block IF expr THEN ... [ELSE ...] ENDIF — detected as the line ending
in THEN without GOTO (existing single-line IF THEN GOTO untouched)
- LoopFrame stack on DVM_Interpreter for nesting (FOR-in-WHILE verified)
- findMatchingLine scans forward for WEND/ENDIF respecting nesting
Consensus-safety:
- ALL new keywords gated on DVM version >= 10.0.0 (contract must call
version("10.0.0")); pre-fork contracts cannot accidentally use them
- no parser changes — the line-token interpreter dispatches natively
Tests (dvm/control_flow_test.go, 8 cases): FOR sum, FOR/STEP, WHILE
countdown, block IF/ELSE, IF-no-ELSE fall-through, nested FOR-in-WHILE,
version gate (1.2.3), no-version gate (0.0.0). All green.
Also carries the build-manifest fix (go.mod/go.sum) for fresh-clone builds.
The second P0 language item (spec dero-improvements-agenda.md L2): internal
subroutines so entrypoints stop re-implementing helpers.
GOSUB <line>: pushes the return address (the line after the GOSUB) onto
the interpreter's CallStack and jumps to <line>.
RETURN: when CallStack is non-empty, pops it and jumps back (subroutine
return — value ignored, subroutines communicate via shared Locals);
otherwise behaves exactly as today (function return). Fully
backward-compatible: existing contracts never push a CallStack.
Gated on DVM version >= 10.0.0 like L1 (contract must call
version("10.0.0")). Nests correctly (GOSUB-in-GOSUB, GOSUB-in-FOR).
Tests (dvm/control_flow_l2_test.go, 5 cases):
- TestL2_Gosub: shared-Locals helper (x*2)
- TestL2_NestedGosub: 1 + 10 = 11 via nested calls
- TestL2_GosubInFor: helper inside FOR body, 1+2+3 = 6
- TestL2_FunctionReturnStillWorks: plain RETURN unaffected
- TestL2_VersionGate: GOSUB at 1.2.3 rejected
Stacks on L1 (feature/dvm-l1-control-flow-pr, PR DEROFDN#101).
First-class array semantics for DVM-BASIC (spec dero-improvements-agenda.md
L3, P1): DIM a(n) AS Uint64|String creates a zero-filled RAM array
(indices 0..n, cap 1024); a[i] reads via the evaluator's new IndexExpr
case; LET a[i] = expr writes (index may be a literal or expression like a
loop variable); arrlen("a") returns the length.
Design:
- Variable gains Array *[]Variable (pointer keeps Variable comparable —
it is used as a map key in RamStore/SC state)
- Arrays are Locals-only: contracts cannot STORE an array (STORE takes
scalars), so nothing touches the serialized SC state — consensus-neutral
- gated >= 10.0.0 like L1/L2 (contract must call version("10.0.0"))
- composes with L1: FOR i = 0 TO n / a[i] = ... / NEXT i
Tests (dvm/control_flow_l3_test.go, 4 cases): array basics (set/read/
arrlen), FOR-loop fill (sum of squares 0..10 = 385), string arrays,
version gate (1.2.3 rejected).
Full dvm suite green. Stacks on L2 (feature/dvm-l2-subroutines, PR DEROFDN#103).
mapkeys() -> String: comma-separated, sorted keys of the contract's state visible during execution (spec dero-improvements-agenda.md L4, P1). The effective key set is the union of: - RamStore: keys loaded from disk (via DiskLoader) during this call - RawKeys: keys written during this call (TX_Storage.RawKeys) Batch/paged contracts can now iterate their stored keys instead of hand-rolling key sets. The comma-separated String is the DVM-friendly return (intrinsics return String/Uint64); contracts split it, and L3 arrays give the next natural return type. Gated >= 10.0.0 like L1/L2/L3. Tests (dvm/control_flow_l4_test.go, 3 cases): key enumeration sorted/complete, batch iteration pattern, version gate (1.2.3 rejected). Full dvm suite green. Stacks on L3 (feature/dvm-l3-arrays, PR DEROFDN#107).
This was referenced Aug 23, 2026
…ndor) Same two fixes as the sibling PRs: remove the l.Operation.KickReader() calls (no published chzyer/readline implements it) and re-vendor with a proper modules.txt. Fresh-clone go build now succeeds without -mod=mod.
Author
|
Superseded by PR #126 — the consolidated language package. Same code, one reviewable PR with no vendor noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
L4 from the DVM-BASIC language agenda (P1):
mapkeys() -> String— map enumeration for SC state. Batch/paged contracts can iterate their stored keys instead of hand-rolling key sets.The intrinsic
The effective key set is the union of:
RamStore— keys loaded from disk (via DiskLoader) during this callRawKeys— keys written during this call (TX_Storage.RawKeys)Keys are the String/Uint64 values of the stored Variables, unmarshaled, deduped, sorted, and joined. The comma-separated String is the DVM-friendly return (intrinsics return String/Uint64); contracts split it for iteration, and L3 arrays give the next natural return type.
Why it matters
Today a contract that batches/pages state must hand-roll its key set (store a counter, maintain a registry). With
mapkeys, the keys themselves are enumerable — combined with L1'sFORand L3's arrays, a contract can:Consensus safety
>= 10.0.0like L1/L2/L3 — pre-fork contracts can't use itTests (
dvm/control_flow_l4_test.go, 3 cases)TestL4_MapkeysBasic"alpha,beta,gamma"(sorted)TestL4_MapkeysIterateTestL4_MapkeysVersionGate1.2.3Full dvm suite green.
Relationship
>= 10.0.0gate; L3 arrays give the next natural return typeBranch:
feature/dvm-l4-mapkeysin the forkliqdmetal/derohe-improvements-by-liqdmetal(stacked onfeature/dvm-l3-arrays).