walletapi/rpc: do not return panic stack traces to callers - #68
Open
DHEBP wants to merge 1 commit into
Open
Conversation
The wallet RPC handlers formatted debug.Stack() into the returned error on panic recovery, exposing the wallet binary's absolute path and OS username to the RPC caller. Log the stack at V(1) and return a generic error, matching the daemon RPC handlers.
DHEBP
force-pushed
the
fix/walletapi-rpc-disclosure
branch
from
August 16, 2026 23:44
0d740d2 to
c63a7af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
walletapi/rpcserverhandlers formatteddebug.Stack()into the returned error on panic recovery, so a panic surfaced the wallet binary's absolute path and OS username to the RPC caller.Change
The 10 wallet RPC handlers now log the stack at
V(1)and return a genericinternal error, mirroring the daemon-side handlers. Stack traces remain in the node's own logs.Notes
--rpc-server) and binds localhost by default, so exposure is lower than the daemon side — this is hygiene / consistency.