Skip to content

fix: add shebang to run_detached script#8716

Open
natthan-pigoux wants to merge 1 commit into
DIRACGrid:integrationfrom
natthan-pigoux:fix_host_submit_job
Open

fix: add shebang to run_detached script#8716
natthan-pigoux wants to merge 1 commit into
DIRACGrid:integrationfrom
natthan-pigoux:fix_host_submit_job

Conversation

@natthan-pigoux

Copy link
Copy Markdown
Contributor

Add shebang to run_detached.sh script to run subprocess without shell=True which results as a bandit security issue.

closes #8715

runFile = open(runFileName, "w")
runFile.write(
"""
#!/bin/bash

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I think this would need to be on the line above (directly after the """) to get it into the very beginning of the file, or have I misunderstood?

Regards,
Simon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: run_detached.sh script is ran as a binary by SSHComputingElement

2 participants