Improvement: Added Readme for mesh handle tutorials, wiki links still missing. - #2372
Improvement: Added Readme for mesh handle tutorials, wiki links still missing.#2372Vyp3er wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2372 +/- ##
=======================================
Coverage 82.28% 82.28%
=======================================
Files 125 125
Lines 20701 20701
=======================================
Hits 17033 17033
Misses 3668 3668 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| [Mesh Handle Tutorials](../tutorials/mesh_handle/README.md) | ||
| These tutorials can be followed instead of the original t8code tutorials. They explain working with t8code with the help of the | ||
| [mesh_handle](../mesh_handle/README.md) interface. | ||
| Please note, that the mesh handle tutorials start at step 2, because the first 2 steps are the same as in the original tutorials. Please complete these first and then come back to the [Mesh Handle Tutorial Overview](../tutorials/mesh_handle/README.md) |
There was a problem hiding this comment.
| Please note, that the mesh handle tutorials start at step 2, because the first 2 steps are the same as in the original tutorials. Please complete these first and then come back to the [Mesh Handle Tutorial Overview](../tutorials/mesh_handle/README.md) | |
| Please note, that the mesh handle tutorials start at step 2, because the steps 0 and 1 are the same as in the general tutorials. Please complete these first and then come back to the [Mesh Handle Tutorial Overview](../tutorials/mesh_handle/README.md). |
| ## Mesh handle | ||
| [mesh_handle_element_data](mesh_handle/t8_mesh_element_data.cxx) Recreating [step5](./general/t8_step5_element_data.cxx) of the general tutorials but using the mesh handle. | ||
| [Mesh Handle Tutorials](../tutorials/mesh_handle/README.md) | ||
| These tutorials can be followed instead of the original t8code tutorials. They explain working with t8code with the help of the |
There was a problem hiding this comment.
| These tutorials can be followed instead of the original t8code tutorials. They explain working with t8code with the help of the | |
| These tutorials can be followed instead of the general t8code tutorials. They explain working with t8code with the help of the |
One idea is that the mesh handle is the only entry point of t8code which is why we should not name this "original"
| @@ -0,0 +1,33 @@ | |||
| # Mesh handle tutorials | |||
|
|
|||
| This is the tutorial collection for the [mesh_handle](../mesh_handle/README.md) interface of `t8code`. | |||
There was a problem hiding this comment.
| This is the tutorial collection for the [mesh_handle](../mesh_handle/README.md) interface of `t8code`. | |
| This is the tutorial collection for the [mesh_handle](../../mesh_handle/README.md) interface of `t8code`. |
|
|
||
| This is the tutorial collection for the [mesh_handle](../mesh_handle/README.md) interface of `t8code`. | ||
|
|
||
| The `mesh handle` Interface acts as a bridge between the user and the original t8code library. When using the mesh handle, t8code acts as if it is working with usual unstructured meshes. |
There was a problem hiding this comment.
| The `mesh handle` Interface acts as a bridge between the user and the original t8code library. When using the mesh handle, t8code acts as if it is working with usual unstructured meshes. | |
| The `mesh handle` interface acts as a bridge between the user and the tree-based t8code library. When using the mesh handle, t8code acts as if it is working with unstructured meshes. |
| This is the tutorial collection for the [mesh_handle](../mesh_handle/README.md) interface of `t8code`. | ||
|
|
||
| The `mesh handle` Interface acts as a bridge between the user and the original t8code library. When using the mesh handle, t8code acts as if it is working with usual unstructured meshes. | ||
| For more information about the [mesh_handle](../mesh_handle/README.md), look into the readme there. |
There was a problem hiding this comment.
| For more information about the [mesh_handle](../mesh_handle/README.md), look into the readme there. | |
| Have a look at the [mesh_handle README](../../mesh_handle/README.md) for more information. |
| Create a coarse mesh, output it to vtu and destroy it. (This links leads to the original t8code tutorials, come back after this step to use the mesh handle tutorials instead.) | ||
|
|
||
| [step2] - | ||
| Create a uniform mesh, get its number of local and global elements, output it to vtu and destroy it. |
There was a problem hiding this comment.
| Create a uniform mesh, get its number of local and global elements, output it to vtu and destroy it. | |
| Create a uniform mesh, get its number of local and global elements and output it to vtu. |
As we do not really need to destroy it
|
|
||
| Please note, that the mesh handle tutorials start at step 2. This is due to the fact, that [step0](https://github.com/DLR-AMR/t8code/wiki/Step-0---Hello-World) and [step1](https://github.com/DLR-AMR/t8code/wiki/Step-1---Creating-a-coarse-mesh) are the same when using the mesh handle so please use the original `t8code` tutorials for these steps. | ||
|
|
||
| ## General |
There was a problem hiding this comment.
Steps ? General is valid for the other folder
| Adapt a mesh according to a user defined criterion. | ||
|
|
||
| [step4] - | ||
| Partitioning, balancing and creating a ghost layer for a mesh. Explains the mesh creation process in more detail. |
There was a problem hiding this comment.
| Partitioning, balancing and creating a ghost layer for a mesh. Explains the mesh creation process in more detail. | |
| Partitioning, balancing and creating a ghost layer for a mesh. |
Or please state what you mean here? Because partition balance and ghost can also be done after mesh creation. What do you explain here in more detail?
| [step4] - | ||
| Partitioning, balancing and creating a ghost layer for a mesh. Explains the mesh creation process in more detail. | ||
|
|
||
| [step5](mesh_handle/t8_mesh_element_data.cxx) - |
There was a problem hiding this comment.
we have to think of the renaming here
| Associating user data with the elements of a mesh. Exchanging ghost values for element user data. Writing element user data to vtu. | ||
|
|
||
| [step6] - | ||
| Going into more detail about mesh handle competence packs. Explaining element data competences and caching. Creating a custom competence. No newline at end of file |
There was a problem hiding this comment.
Maybe one sentence about what competences are about?
Describe your changes here:
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
scripts/internal/find_all_source_files.shto check the indentation of these files.License
doc/(or already has one).