Repository navigation
[CU-86bcy5qta] Add wallet_chart local values; fix trino audience and e2e auth config - #186
Open
angelo-DNAStack wants to merge 3 commits into
Open
angelo-DNAStack wants to merge 3 commits into
angelo-DNAStack wants to merge 3 commits into
Conversation
…onfig helm/values-local.yaml covers every audience this chart's templates reference for dnaservice wallet-render, including trino's resourceUrl as the opaque http://trino.local identifier its APP_AUTH_TRINOOAUTHCLIENT_AUDIENCE expects (see sibling trino repo's own values-local.yaml fix under CU-86bcy5qry) rather than trino's real listening port, which made this service fail to start at all: "No grant for requested audience [http://trino.local]". e2e-tests/e2e-tests.env sets E2E_GLOBAL_METHOD_SECURITY_ENABLED=true to match how this service actually runs locally (SPRING_PROFILES_ACTIVE=wallet-auth, whose app.auth.global-method-security.enabled defaults to true, same as alpha/beta/prod) -- the e2e suite's own default assumes it's off (as it is for the no-auth/basic-auth profiles) and skips sending a Bearer token entirely, which the real profile's security filter chain rejects before this app's custom GA4GH-Search challenge logic ever runs. With both fixes, 37/38 e2e tests pass locally (up from a startup crash). The one remaining failure (getTables_should_returnAPageIndexMatchingTheNextPageTrail, a Trino "Cannot check and eventually update SQL schema" error) is unrelated to wallet config -- root-caused to accumulated stray/orphaned Postgres catalog files in trino's own local-dev/etc/catalog/ from unrelated past e2e runs, a separate local-environment cleanup issue. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…d-method-security-CU-86bcy5qta
mpanik-dnastack
approved these changes
Nov 17, 2026
mpanik-dnastack
left a comment
There was a problem hiding this comment.
Verdict: merge with fixes. Reviewed at efb7e9d. Approving with the fix below to go in before merge.
Stale data_lake once DNAstack/trino#200 renames the local catalog to publisher:
helm/values-local.yaml:55-57(test.showSchemaForCatalogName,test.showTableForCatalogSchemaName);e2e-tests/.run/Data Connect Trino E2E Tests - Local.run.xml:15-16(not in this diff).
No GitHub checks ran on this PR.
…test config and docs The local catalog is renamed from data_lake to publisher to match real deployments; update the chart's local test values, the IDE run configuration and the e2e README. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Author
|
Fixed in 4fecd3e: helm/values-local.yaml (test.showSchemaForCatalogName), the IDE run configuration 'Data Connect Trino E2E Tests - Local.run.xml' and the e2e README now use the publisher catalog. A search of the repo finds no other data_lake references. values-local.yaml still parses and dnaservice wallet-render still renders the 3 Wallet CRDs. I have not run the e2e tests, which need the local stack with the renamed Trino catalog from DNAstack/trino#200. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
helm/values-local.yamlsodnaservice wallet-rendercan extract this chart's WalletClient/WalletPolicy CRDs locally.trino.resourceUrlis set to the opaquehttp://trino.localidentifier (matchingapplication.yml's own default forAPP_AUTH_TRINOOAUTHCLIENT_AUDIENCEand the mini-cluster's historical grant), not trino's real listening port — the previous assumption there broke this service's startup entirely.e2e-tests/e2e-tests.envsettingE2E_GLOBAL_METHOD_SECURITY_ENABLED=trueto match how this service actually runs locally (SPRING_PROFILES_ACTIVE=wallet-auth, whoseapp.auth.global-method-security.enableddefaults totrue— same as alpha/beta/prod). The e2e suite's own default assumes it's off, so it skipped sending a Bearer token entirely, which the real profile's security filter chain rejected outright.Context
This service couldn't start locally at all before this fix ("No grant for requested audience [http://trino.local]"). A companion audience fix shipped in trino's own PR (CU-86bcy5qry).
Test plan
dnaservice test data-connect-trino— 37/38 passed (up from a startup crash)getTables_should_returnAPageIndexMatchingTheNextPageTrail, a Trino "Cannot check and eventually update SQL schema" error) is unrelated to wallet config — root-caused to accumulated stray/orphaned Postgres catalog files in trino's ownlocal-dev/etc/catalog/from unrelated past e2e runs. Flagging as a separate local-environment cleanup item, not blocking this PR.