Skip to content

[CU-86bcy5qta] Add wallet_chart local values; fix trino audience and e2e auth config - #186

Open
angelo-DNAStack wants to merge 3 commits into
mainfrom
Fix-trino-audience-and-method-security-CU-86bcy5qta
Open

angelo-DNAStack wants to merge 3 commits into
mainfrom
Fix-trino-audience-and-method-security-CU-86bcy5qta

Conversation

@angelo-DNAStack

Copy link
Copy Markdown
Contributor

Summary

  • Adds helm/values-local.yaml so dnaservice wallet-render can extract this chart's WalletClient/WalletPolicy CRDs locally.
  • trino.resourceUrl is set to the opaque http://trino.local identifier (matching application.yml's own default for APP_AUTH_TRINOOAUTHCLIENT_AUDIENCE and the mini-cluster's historical grant), not trino's real listening port — the previous assumption there broke this service's startup entirely.
  • Adds e2e-tests/e2e-tests.env setting E2E_GLOBAL_METHOD_SECURITY_ENABLED=true to match how this service actually runs locally (SPRING_PROFILES_ACTIVE=wallet-auth, whose app.auth.global-method-security.enabled defaults to true — same as alpha/beta/prod). The e2e suite's own default assumes it's off, so it skipped sending a Bearer token entirely, which the real profile's security filter chain rejected outright.

Context

This service couldn't start locally at all before this fix ("No grant for requested audience [http://trino.local]"). A companion audience fix shipped in trino's own PR (CU-86bcy5qry).

Test plan

  • dnaservice test data-connect-trino — 37/38 passed (up from a startup crash)
  • The one remaining failure (getTables_should_returnAPageIndexMatchingTheNextPageTrail, a Trino "Cannot check and eventually update SQL schema" error) is unrelated to wallet config — root-caused to accumulated stray/orphaned Postgres catalog files in trino's own local-dev/etc/catalog/ from unrelated past e2e runs. Flagging as a separate local-environment cleanup item, not blocking this PR.

…onfig

helm/values-local.yaml covers every audience this chart's templates reference for
dnaservice wallet-render, including trino's resourceUrl as the opaque http://trino.local
identifier its APP_AUTH_TRINOOAUTHCLIENT_AUDIENCE expects (see sibling trino repo's own
values-local.yaml fix under CU-86bcy5qry) rather than trino's real listening port, which
made this service fail to start at all: "No grant for requested audience
[http://trino.local]".

e2e-tests/e2e-tests.env sets E2E_GLOBAL_METHOD_SECURITY_ENABLED=true to match how this
service actually runs locally (SPRING_PROFILES_ACTIVE=wallet-auth, whose
app.auth.global-method-security.enabled defaults to true, same as alpha/beta/prod) --
the e2e suite's own default assumes it's off (as it is for the no-auth/basic-auth
profiles) and skips sending a Bearer token entirely, which the real profile's security
filter chain rejects before this app's custom GA4GH-Search challenge logic ever runs.

With both fixes, 37/38 e2e tests pass locally (up from a startup crash). The one
remaining failure (getTables_should_returnAPageIndexMatchingTheNextPageTrail, a Trino
"Cannot check and eventually update SQL schema" error) is unrelated to wallet config --
root-caused to accumulated stray/orphaned Postgres catalog files in trino's own
local-dev/etc/catalog/ from unrelated past e2e runs, a separate local-environment
cleanup issue.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@platform-automation-dnastack

Copy link
Copy Markdown

@angelo-DNAStack angelo-DNAStack changed the title [CU-86bcy5qta] Add wallet_chart local values for data-connect-trino [CU-86bcy5qta] Add wallet_chart local values; fix trino audience and e2e auth config Nov 16, 2026

@mpanik-dnastack mpanik-dnastack left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: merge with fixes. Reviewed at efb7e9d. Approving with the fix below to go in before merge.

Stale data_lake once DNAstack/trino#200 renames the local catalog to publisher:

  • helm/values-local.yaml:55-57 (test.showSchemaForCatalogName, test.showTableForCatalogSchemaName);
  • e2e-tests/.run/Data Connect Trino E2E Tests - Local.run.xml:15-16 (not in this diff).

No GitHub checks ran on this PR.

…test config and docs

The local catalog is renamed from data_lake to publisher to match real deployments; update the chart's local test values, the IDE run configuration and the e2e README.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@angelo-DNAStack

Copy link
Copy Markdown
Contributor Author

Fixed in 4fecd3e: helm/values-local.yaml (test.showSchemaForCatalogName), the IDE run configuration 'Data Connect Trino E2E Tests - Local.run.xml' and the e2e README now use the publisher catalog. A search of the repo finds no other data_lake references. values-local.yaml still parses and dnaservice wallet-render still renders the 3 Wallet CRDs. I have not run the e2e tests, which need the local stack with the renamed Trino catalog from DNAstack/trino#200.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants