Repository navigation
[CU-86bd1pece] List catalogs with SHOW CATALOGS - #188
Merged
Merged
Conversation
Listing tables read system.metadata.catalogs, which collection-service's tenant catalog check refuses in a tenant, so nobody could list a tenant's tables. Trino answers SHOW CATALOGS from its catalog list, filtered by the access control's filterCatalogs and sorted by name, without an access check on a table in the system catalog.
angelo-DNAStack
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Listing Data Connect tables in a tenant was refused for every caller, because it read Trino's
system.metadata.catalogstable, which a tenant may not reach.Data Connect now lists catalogs with
SHOW CATALOGS, which Trino answers from the catalogs the caller may reach, without reading a table in thesystemcatalog.