Repository navigation
fix(projects): save project attachments in the uploads volume - #884
Merged
evilguy4000 merged 1 commit intoNov 17, 2026
Merged
evilguy4000 merged 1 commit into
evilguy4000 merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uploading an attachment to a project returns 500 in the Docker image:
The route saves to
uploads/project_attachmentsunder the project root, which thetimetrackeruser can't create in the image. When it does work (from source), the file is outside the compose volumes and is lost when the container is recreated.#606 moved the client, quote, comment and other attachment routes to
app/static/uploads/<name>, which is theapp_uploadsvolume, but not this one. This uses the same folder for project attachments. Download and delete already resolve the stored path withresolve_stored_upload_path, so they work with it.Added
tests/test_project_attachments.py, which uploads through the route and checks the file is saved underapp/static/uploads; it fails without the change. The project test files pass.