Repository navigation
fix(backup): include receipts and avatars from UPLOAD_FOLDER - #885
Merged
evilguy4000 merged 1 commit intoNov 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The full backup (Admin > Backups,
flask backup_create, scheduled backups) leaves out expense receipts and user avatars, so they are lost after a restore.create_backupzips onlyapp/static/uploads. Receipts and avatars are saved underUPLOAD_FOLDER(/data/uploadsby default, its ownapp_datavolume in Docker), so they never go into the archive. The backups page says uploaded files are included.The archive now also has
UPLOAD_FOLDERunderdata_uploads/, without thebackupsfolder that sits inside it by default, andrestore_backupcopies it back toUPLOAD_FOLDER. The two copy loops share one helper.Added
tests/test_backup_upload_folder.py: it creates a backup with a receipt inUPLOAD_FOLDER, deletes the receipt, restores, and checks it is back. It fails without the change. The backup and import/export tests pass.