Repository navigation
fix(support): improve Supporter key conversion funnel - #887
Merged
Merged
Conversation
Lead CTAs with funding, badge, and clean PDFs; keep tips secondary; stop BMC clicks from suppressing key prompts; deep-link system_id on every checkout path; drop orphaned banner JS and lock A/B to key_first.
Tip €5/€10/€25 buttons used href="#" and fell through to the current page when JS blocked the old license-page fallback; give them real BMC links and defaults. Use the canonical /support checkout path with system_id instead of support.html.
Stop assigning checkout URLs into DOM href attributes, reject data/vbscript schemes, and validate tip hosts via hostname equality. Apply black to support_ui, main, and context_processors so Lint passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?system_id=tohttps://timetracker.drytrix.com/support./current-page#, remove orphaned support-banner JS, and document key-vs-tip conversion measurement.Test plan
#/ current page)/support?system_id=<uuid>(no.html) from dashboard, donate, license, admin, and aboutpytest tests/test_support_ui_urls.py tests/test_support_services.py