[DURACOM-506] added spellcheck support - #5935
Open
steph-ieffam wants to merge 2 commits into
Open
Conversation
10 tasks
EikLoe
suggested changes
Jul 27, 2026
EikLoe
left a comment
Member
There was a problem hiding this comment.
Hi @steph-ieffam,
thanks for this new feature. I tested it and it worked perfectly.
The code looks fine, too. The only thing I wanted to ask: could you add the spellcheck feature to the spec test of the search-results.component.spec.ts.
For example:
it('should display link based on spellcheck', () => {
(comp as any).searchResults = { payload: { page: { length: 0 }, spellCheckSuggestions: ['test'] } };
(comp as any).spellCheckSuggestions = ['test'];
(comp as any).searchConfig = { query: 'testi' };
fixture.detectChanges();
const linkDes = fixture.debugElement.queryAll(By.directive(QueryParamsDirectiveStub));
// get attached link directive instances
// using each DebugElement's injector
const routerLinkQuery = linkDes.map((de) => de.injector.get(QueryParamsDirectiveStub)).filter(
val => val.queryParams.query === 'test');
expect(routerLinkQuery.length).toBe(1, 'should have 1 router link with query params "test"');
});
Contributor
Author
|
Hey @EikLoe thanks for the suggestion I totally forgot to introduce any testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Relates to
DSpace/RestContract#359
DSpace/DSpace#12792
Description
Added support for Spellcheck "did you mean?" feature whose porting from version 6 was not completed
Instructions for reviewers
./dspace index-discovery --spellcheckerto rebuild the spellchecker indexAlternatively this test could be run using any other item in the repository trying to use a misspelled query.
The result strictly depends on the on the content indexed on Solr as already defined in the Solr configuration
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.