Repository navigation
chore(coverage): подтянуть ratchet frontend-common и убрать неиспользуемый импорт (LOS-54) - #450
Merged
Merged
Conversation
…уемый импорт (LOS-54) Ratchet frontend-common в reusable-frontend-tests.yml отставал от vitest.config.ts (branches 82.60 против цели 90): поднят до измеренных 95.7 lines и 90.4 branches. В test_api_scripts.py удалён неиспользуемый import pytest (ruff F401). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UpqaGVW1WcMuhU2CWMoovN
Contributor
Author
|
@codex review Generated by Claude Code |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
До: ratchet frontend-common в
reusable-frontend-tests.ymlтребовал только 94.65% lines и 82.60% branches, хотяvitest.config.tsи цель эпика LOS-54 требуют ≥90% branches. Вtest_api_scripts.pyостался неиспользуемыйimport pytest(ruff F401), который ломалruff checkдля тестов script-service.После: workflow-ratchet frontend-common равен измеренным значениям (95.7% lines, 90.4% branches), поэтому регресс покрытия ниже цели эпика сразу виден в CI. Неиспользуемый импорт убран,
ruff checkдля файла чистый.Тип изменений
Что было сделано
.github/workflows/reusable-frontend-tests.yml:--min-lines 95.7 --min-branches 90.4для frontend-common.projects/backend/services/script-service/tests/integration/test_api_scripts.py: удалёнimport pytest, импорты отсортированы черезruff --fix.Как тестировать
cd projects/frontend/common && COVERAGE_ENFORCE_RATCHET=true npx vitest run --coverage: 38 тестов проходят, 95.72% lines и 90.43% branches.ruff check tests/integration/test_api_scripts.pyв script-service: без замечаний.Checklist
Breaking Changes
Связанные задачи
Follow-up к LOS-54 (эпик уже в Done, остались только эти хвосты).
Generated by Claude Code