Repository navigation
Check DDAI reconciliation errors in operator check - #3548
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 676f7ebba2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🛑 Gate Violations
ℹ️ Info🎯 Code Coverage (details) Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 0de9f6c | Docs | Give us feedback! |
What does this PR do?
Check for DDAI reconciliation errors in operator check
Motivation
https://datadoghq.atlassian.net/browse/CONTP-2146
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Trigger a DDAI reconcile error:
kubectl patch dda <dda> --type=merge -p '{"spec":{"override":{"clusterAgent":{"createRbac":false,"serviceAccountName":"INVALID_NAME"}}}}'Run the check:
CHECK_TIMEOUT_MINUTES=3 go run ./cmd/check-operator upgrade <dda>It should report the same reconcile error in the DatadogAgentInternal status and remain blocked.
In another terminal, fix the DDA:
kubectl patch dda <dda> --type=json -p='[{"op":"remove","path":"/spec/override/clusterAgent/createRbac"}, {"op":"remove","path":"/spec/override/clusterAgent/serviceAccountName"}]'The DDAI condition should become:
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel