Skip to content

Check DDAI reconciliation errors in operator check - #3548

Merged
khewonc merged 2 commits into
mainfrom
khewonc/check-ddai-reconcile-errors
Oct 9, 2026
Merged

khewonc merged 2 commits into
mainfrom
khewonc/check-ddai-reconcile-errors

Conversation

@khewonc

@khewonc khewonc commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Check for DDAI reconciliation errors in operator check

Motivation

https://datadoghq.atlassian.net/browse/CONTP-2146

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

  • Trigger a DDAI reconcile error:
    kubectl patch dda <dda> --type=merge -p '{"spec":{"override":{"clusterAgent":{"createRbac":false,"serviceAccountName":"INVALID_NAME"}}}}'

  • Run the check:
    CHECK_TIMEOUT_MINUTES=3 go run ./cmd/check-operator upgrade <dda>

  • It should report the same reconcile error in the DatadogAgentInternal status and remain blocked.

  • In another terminal, fix the DDA:
    kubectl patch dda <dda> --type=json -p='[{"op":"remove","path":"/spec/override/clusterAgent/createRbac"}, {"op":"remove","path":"/spec/override/clusterAgent/serviceAccountName"}]'

  • The DDAI condition should become:

  {
    "message": "DatadogAgent reconcile ok",
    "reason": "DatadogAgent_reconcile_ok",
    "status": "False",
    "type": "DatadogAgentReconcileError"
  }
  • The operator check should succeed after the next poll

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@khewonc khewonc added this to the v1.32.0 milestone Oct 2, 2026
@khewonc
khewonc requested a review from a team October 2, 2026 20:20
@khewonc khewonc added the bug Something isn't working label Oct 2, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 676f7ebba2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread cmd/check-operator/upgrade/upgrade.go
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T20:24:46.115568Z 676f7eb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Code Coverage

🛑 Gate Violations

🎯 1 Code Coverage issue detected

A Patch coverage percentage gate may be blocking this PR.

• Patch coverage: 50.00% (threshold: 80.00%)

ℹ️ Info

🎯 Code Coverage (details)
• Patch Coverage: 50.00%
• Overall Coverage: 53.50% (+0.98%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0de9f6c | Docs | Give us feedback!

@khewonc
khewonc merged commit 149651e into main Oct 9, 2026
37 of 40 checks passed
@khewonc
khewonc deleted the khewonc/check-ddai-reconcile-errors branch October 9, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working team/container-platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants